Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Align the cfg compilation with the socket2 #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linyihai
Copy link

This shoud fixe hyperium/hyper#3817

@seanmonstar
Copy link
Member

I don't think it can be done with the cfg macro, since that still compiles to just an if expression, the code is still compiled and those methods don't exist. The cfg attribute is what is needed to prevent compiling methods calls that don't exist on that target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants