Skip to content

Commit a28a39c

Browse files
authored
Update tracing-subscriber and use tracing-tree when testing (#586)
This makes reading the logs way easier on the eyes.
1 parent d92ba1c commit a28a39c

File tree

2 files changed

+14
-36
lines changed

2 files changed

+14
-36
lines changed

tests/h2-support/Cargo.toml

+3-1
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ edition = "2018"
77
[dependencies]
88
h2 = { path = "../..", features = ["stream", "unstable"] }
99

10+
atty = "0.2"
1011
bytes = "1"
1112
tracing = "0.1"
12-
tracing-subscriber = { version = "0.2", default-features = false, features = ["fmt", "chrono", "ansi"] }
13+
tracing-subscriber = { version = "0.3", default-features = false, features = ["fmt"] }
14+
tracing-tree = "0.2"
1315
futures = { version = "0.3", default-features = false }
1416
http = "0.2"
1517
tokio = { version = "1", features = ["time"] }

tests/h2-support/src/trace.rs

+11-35
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,17 @@
1-
use std::{io, str};
21
pub use tracing;
32
pub use tracing_subscriber;
43

5-
pub fn init() -> tracing::dispatcher::DefaultGuard {
6-
tracing::subscriber::set_default(
7-
tracing_subscriber::fmt()
8-
.with_max_level(tracing::Level::TRACE)
9-
.with_span_events(tracing_subscriber::fmt::format::FmtSpan::CLOSE)
10-
.with_writer(PrintlnWriter { _p: () })
11-
.finish(),
12-
)
13-
}
14-
15-
struct PrintlnWriter {
16-
_p: (),
17-
}
4+
use tracing_subscriber::layer::SubscriberExt;
5+
use tracing_subscriber::util::SubscriberInitExt;
186

19-
impl tracing_subscriber::fmt::MakeWriter for PrintlnWriter {
20-
type Writer = PrintlnWriter;
21-
fn make_writer(&self) -> Self::Writer {
22-
PrintlnWriter { _p: () }
23-
}
24-
}
25-
26-
impl io::Write for PrintlnWriter {
27-
fn write(&mut self, buf: &[u8]) -> io::Result<usize> {
28-
let s = str::from_utf8(buf).map_err(|e| io::Error::new(io::ErrorKind::InvalidInput, e))?;
29-
println!("{}", s);
30-
Ok(s.len())
31-
}
32-
33-
fn write_fmt(&mut self, fmt: std::fmt::Arguments<'_>) -> io::Result<()> {
34-
println!("{}", fmt);
35-
Ok(())
36-
}
7+
pub fn init() -> tracing::dispatcher::DefaultGuard {
8+
let use_colors = atty::is(atty::Stream::Stdout);
9+
let layer = tracing_tree::HierarchicalLayer::default()
10+
.with_writer(tracing_subscriber::fmt::writer::TestWriter::default())
11+
.with_indent_lines(true)
12+
.with_ansi(use_colors)
13+
.with_targets(true)
14+
.with_indent_amount(2);
3715

38-
fn flush(&mut self) -> io::Result<()> {
39-
Ok(())
40-
}
16+
tracing_subscriber::registry().with(layer).set_default()
4117
}

0 commit comments

Comments
 (0)