Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests that fail because they throw error don't report with a ❌ #72

Open
didibus opened this issue Jan 22, 2023 · 0 comments
Open

Tests that fail because they throw error don't report with a ❌ #72

didibus opened this issue Jan 22, 2023 · 0 comments

Comments

@didibus
Copy link

didibus commented Jan 22, 2023

When a test fails because it throws, it seems that it's reported differently:

(rcf/tests
 (throw (ex-info "" {}))
 := 10)

Will report:

ERROR in () (:)
expected: (hyperfiddle.rcf/= (throw (ex-info "" {})) 10)
  actual: clojure.lang.ExceptionInfo: 
{}
 at ...

Where-as:

(rcf/tests
 20
 := 10)

Will report:

❌ FAIL in () (...:460)
expected: (= 20 10)
  actual: (not (= 20 10))

I don't mind that it says ERROR instead of FAIL, but it be nice to still have a big red ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant