From b019bd56aea954a712e425494ff6a0ee92657855 Mon Sep 17 00:00:00 2001 From: Jeyachandran Rathnam Date: Thu, 21 Sep 2023 12:33:53 -0500 Subject: [PATCH 1/2] Contributing docs for Windows (#20) --- CONTRIBUTING.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8f22169f0..fd9b5e802 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -44,6 +44,14 @@ HYPERDX_API_KEY= docker compose -f ./docker-compose The core services are all hot-reloaded, so you can make changes to the code and see them reflected in real-time. +### Windows + +If you are running WSL 2, Hot module reload on Nextjs (Frontend) does not work out of the box on windows when run natively on docker. The fix here is to open project directory in WSL and run the above docker compose commands directly in WSL. Note that the project directory should not be under /mnt/c/ directory. You can clone the git repo in /home/{username} for example. + +To develop from WSL, follow instructions [here](https://code.visualstudio.com/docs/remote/wsl). + +## Additional support + If you need help getting started, [join our Discord](https://discord.gg/FErRRKU78j) and we're more than happy to -get you set up! +get you set up! \ No newline at end of file From 36cbc3ded0dce690a9bb68d72658b8295ca7ef1b Mon Sep 17 00:00:00 2001 From: Ikko Eltociear Ashimine Date: Fri, 22 Sep 2023 02:46:06 +0900 Subject: [PATCH 2/2] fix typo in CreateLogAlertModal.tsx (#18) Co-authored-by: Warren <5959690+wrn14897@users.noreply.github.com> --- packages/app/src/CreateLogAlertModal.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/app/src/CreateLogAlertModal.tsx b/packages/app/src/CreateLogAlertModal.tsx index e95dbeb6d..6938400a3 100644 --- a/packages/app/src/CreateLogAlertModal.tsx +++ b/packages/app/src/CreateLogAlertModal.tsx @@ -259,7 +259,7 @@ export default function CreateLogAlertModal({ }, onError: () => { toast.error( - 'An error occured. Please contact support for more details.', + 'An error occurred. Please contact support for more details.', ); }, }); @@ -354,7 +354,7 @@ export default function CreateLogAlertModal({ onSavedSearchCreateSuccess(savedSearch.data); } catch (e) { toast.error( - 'An error occured while saving the search for this alert. Please contact support for more details.', + 'An error occurred while saving the search for this alert. Please contact support for more details.', ); return; } @@ -381,14 +381,14 @@ export default function CreateLogAlertModal({ }, onError: () => { toast.error( - 'An error occured. Please contact support for more details.', + 'An error occurred. Please contact support for more details.', ); }, }, ); } else { toast.error( - 'An error occured while saving the search for this alert. Please contact support for more details.', + 'An error occurred while saving the search for this alert. Please contact support for more details.', ); } }} @@ -433,7 +433,7 @@ export default function CreateLogAlertModal({ }, onError: () => { toast.error( - 'An error occured. Please contact support for more details.', + 'An error occurred. Please contact support for more details.', ); }, },