Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attestation validators for know attestation types #29

Closed
bitbeckers opened this issue Jan 31, 2025 · 0 comments · Fixed by #30
Closed

Add attestation validators for know attestation types #29

bitbeckers opened this issue Jan 31, 2025 · 0 comments · Fixed by #30
Assignees
Labels
enhancement New feature or request

Comments

@bitbeckers
Copy link
Contributor

Describe the feature you'd like to request

To make sure a created attestation contains data that we can support, add a Validator class for attestation.

Describe the solution you'd like

The validator should not only check on the schema, but also fields like chainID, contractAddress, and tokenID.

  • chainID should be supported
  • contractAddress should be known
  • tokenID should be a valid hypercert claim tokenID (e.g. the baseType tokenID not a fraction instance)

Describe alternatives you've considered

Yooloing data but that appears to break the API as reported in hypercerts-org/hypercerts-indexer#253

@bitbeckers bitbeckers linked a pull request Feb 3, 2025 that will close this issue
@bitbeckers bitbeckers added the enhancement New feature or request label Feb 3, 2025
@bitbeckers bitbeckers self-assigned this Feb 3, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in Hypercerts dev team daily ops Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant