Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove address wildcards from "Features" list in README #38

Open
Cazfri opened this issue Feb 17, 2020 · 0 comments
Open

Remove address wildcards from "Features" list in README #38

Cazfri opened this issue Feb 17, 2020 · 0 comments

Comments

@Cazfri
Copy link

Cazfri commented Feb 17, 2020

If I'm understanding correctly from #10 and the following code:

go-osc/osc/osc.go

Lines 124 to 128 in 85fee7f

for _, chr := range "*?,[]{}# " {
if strings.Contains(addr, fmt.Sprintf("%c", chr)) {
return errors.New("OSC Address string may not contain any characters in \"*?,[]{}#")
}
}

wildcards in addresses are not supported.

If the wildcard addressing feature is not implemented, it should not be listed under "Features". It could be listed under a "Feature TODO" section, or discussed in a separate issue, but listing it under "Features" is misleading. Please remove until the feature is implemented. If marked as a "TODO" or "Help requested", enterprising Go devs can more easily recognize potential contributions.

If I'm mistaken and this feature is currently implemented, an example on the README would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant