Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Hydro language docs #1633

Open
2 tasks
jhellerstein opened this issue Jan 7, 2025 · 5 comments
Open
2 tasks

docs: Hydro language docs #1633

jhellerstein opened this issue Jan 7, 2025 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation P1 High priority

Comments

@jhellerstein
Copy link
Collaborator

jhellerstein commented Jan 7, 2025

We need a doc with legal Hydro operators.

  • Generate a landing page in the Hydro docs for Streams, Singletons and Optionals
  • Update each method for those with Rust docs
@jhellerstein jhellerstein self-assigned this Jan 7, 2025
@shadaj
Copy link
Member

shadaj commented Jan 7, 2025

I think the way we should think about this is not as "operators" or a "grammar". It's just a Rust API, the same as tokio or Rust iterators (in particular, the "operators" available vary wildly based on type context). So I don't think it's particularly feasible to auto-gen a page with all the operators, instead we should flesh out the Rustdoc and point to https://hydro.run/rustdoc/hydro_lang/stream/struct.Stream. And also have human-written doc pages for the different collections type to provide more conceptual intuition.

@jhellerstein jhellerstein changed the title docs: Hydro language grammar docs: Hydro language docs Jan 7, 2025
@jhellerstein
Copy link
Collaborator Author

jhellerstein commented Jan 7, 2025 via email

@shadaj
Copy link
Member

shadaj commented Jan 7, 2025

I think the tricky difference is unlike DFIR we have streams vs singletons vs optionals which use independent sets of operators. Also unlike DFIR we can use standard Rust tooling for documenting APIs, so I'd prefer to avoid redundancy and instead have a shortcut to this on the website.

@jhellerstein
Copy link
Collaborator Author

So the key entry points are the following?

We need a landing page for those and then rustdocs for the operators.

@MingweiSamuel MingweiSamuel added the documentation Improvements or additions to documentation label Jan 29, 2025
@MingweiSamuel
Copy link
Member

I agree that it would be nice to have a concise index linking to those three pages and listing/linking all the corresponding methods

@jhellerstein jhellerstein added the P1 High priority label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation P1 High priority
Projects
None yet
Development

No branches or pull requests

3 participants