From 816f090cfd899e9ceab4695e09163378f3eeabf5 Mon Sep 17 00:00:00 2001
From: Piotr Kulasek-Szwed <piotr.kulasek-szwed@hycom.pl>
Date: Sun, 10 Nov 2019 13:02:08 +0100
Subject: [PATCH] Sonar authorization issue #69

---
 .travis.yml                                                  | 5 ++---
 .../mokka/service/payment/DefaultPaymentStatusService.java   | 4 +---
 .../java/pl/hycom/mokka/ui/payment/PaymentController.java    | 1 -
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 7f403e4..bd3563d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,12 +5,11 @@ dist: trusty
 addons:
   sonarcloud:
     organization: hycom
-    token:
-      secure: "$SONAR_TOKEN"
+    token: "$SONAR_TOKEN"
 before_install:
 - cd src
 script:
-  - mvn verify # org.jacoco:jacoco-maven-plugin:prepare-agent
+  - mvn verify org.jacoco:jacoco-maven-plugin:prepare-agent sonar:sonar
 cache:
   directories:
   - "$HOME/.m2/repository"
diff --git a/src/mokka/src/main/java/pl/hycom/mokka/service/payment/DefaultPaymentStatusService.java b/src/mokka/src/main/java/pl/hycom/mokka/service/payment/DefaultPaymentStatusService.java
index 105366d..ef25039 100644
--- a/src/mokka/src/main/java/pl/hycom/mokka/service/payment/DefaultPaymentStatusService.java
+++ b/src/mokka/src/main/java/pl/hycom/mokka/service/payment/DefaultPaymentStatusService.java
@@ -6,7 +6,6 @@
 import freemarker.template.TemplateException;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.tomcat.util.codec.binary.Base64;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.http.ResponseEntity;
 import org.springframework.stereotype.Service;
@@ -19,7 +18,6 @@
 import pl.hycom.mokka.util.validation.HashGenerator;
 
 import javax.annotation.Resource;
-import java.io.File;
 import java.io.IOException;
 import java.io.OutputStreamWriter;
 import java.io.Writer;
@@ -91,7 +89,7 @@ private void updatePaymentStatus(String status, BlueMediaPayment blueMediaPaymen
             log.info("Response status: [{}]", response.getStatusCode());
             log.info("Response body: [{}]", response.getBody());
         } catch (IOException | TemplateException e) {
-            e.printStackTrace();
+            log.error("Error occured when generating payment request", e);
         }
     }
 
diff --git a/src/mokka/src/main/java/pl/hycom/mokka/ui/payment/PaymentController.java b/src/mokka/src/main/java/pl/hycom/mokka/ui/payment/PaymentController.java
index 6f39ec3..2c00fa5 100644
--- a/src/mokka/src/main/java/pl/hycom/mokka/ui/payment/PaymentController.java
+++ b/src/mokka/src/main/java/pl/hycom/mokka/ui/payment/PaymentController.java
@@ -9,7 +9,6 @@
 import org.springframework.web.bind.annotation.ModelAttribute;
 import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestMapping;
-import org.springframework.web.bind.annotation.RequestMethod;
 import org.springframework.web.bind.annotation.RequestParam;
 import org.springframework.web.bind.annotation.ResponseBody;
 import pl.hycom.mokka.service.payment.PaymentStatusService;