Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Unpublish Date #1

Open
mrjarbenne opened this issue Sep 11, 2017 · 17 comments
Open

Require Unpublish Date #1

mrjarbenne opened this issue Sep 11, 2017 · 17 comments

Comments

@mrjarbenne
Copy link
Member

mrjarbenne commented Sep 11, 2017

We use this plugin to allow users to Unpublish content on our Announcements site.

https://github.com/humanmade/Unpublish

Although it's there, many users don't bother to set a date, leaving the Announcement admin having to clean up old posts. Requiring an Unpublish date would be amazing.

@mrjarbenne mrjarbenne changed the title Requirements Require Unpublish Date Sep 12, 2017
@mrjarbenne
Copy link
Member Author

I meant to mention that in order for this to work, we will need to use the Required Fields branch.

https://github.com/fusioneng/publishing-checklist/pull/33

@r-a-y
Copy link
Member

r-a-y commented Sep 18, 2017

Got some follow-up questions:

  • Are these requirements only for certain sites (the Announcements site) or does this need to be enabled network-wide?
  • Are requirements only needed for the 'post' post type?

@mrjarbenne
Copy link
Member Author

Not network enabled: only for our announcement set up.

Required for the 'slides' post type.

Currently unpublish is the only requirement.

@r-a-y
Copy link
Member

r-a-y commented Sep 18, 2017

I've written a small plugin called "Announcements Publishing Checklist".

Activate it on the sites you need to use it on and ensure that both "Publishing Checklist" and "Unpublish" plugins are activated. Next, try creating a slide and see if the checklist works as expected.

I tried this locally on the 'post' type and it works.

@mrjarbenne
Copy link
Member Author

Do I need the Fusion Publishing Checklist, or just yours and Unpublish.

If the Fusion one, is it the "required fields" branch?

@r-a-y
Copy link
Member

r-a-y commented Sep 19, 2017

You need to install Fusion's "Publishing Checklist" plugin (using the required-fields branch) as well as "Unpublish" and the newly-created "Announcements Publishing Checklist" plugin.

@mrjarbenne
Copy link
Member Author

It looks right, but I'm still able to get the slide published without an UnPublish Date.

You can find it up and running here: https://announcementstemplate.commons.hwdsb.on.ca/wp-admin

@r-a-y
Copy link
Member

r-a-y commented Sep 19, 2017

I think the issue is the required-fields branch is only optimized for the 'post' post type.

Let me look into this a bit more.

@r-a-y
Copy link
Member

r-a-y commented Sep 19, 2017

Okay, should work now. Forgot to sync up my changes to production!

Can you try again and let me know if it works?

@mrjarbenne
Copy link
Member Author

Now the button defaults to Submit for Review, and even though I've met the requirements, the post goes as Draft, not Published.

@r-a-y
Copy link
Member

r-a-y commented Sep 19, 2017

Try a new post.

You have to set the Unpublish date, then hit "Submit for Review" and then hit "Publish" again.

That's the way the Publishing Checklist required-fields branch works at the moment.

@mrjarbenne
Copy link
Member Author

Ok. I see that now.

https://github.com/fusioneng/publishing-checklist/pull/33#issuecomment-186585382

It would be nice if the button could be changed to say something like "Check Requirements", then Publish. Submit for Review makes it seem like perhaps we have ripped the ability to publish away from users.

@r-a-y
Copy link
Member

r-a-y commented Sep 19, 2017

I've added a JS snippet that dynamically switches out the "Submit for Review" label for "Check Requirements".

Let me know if that is okay with you. I'll comment on that PR once we like these changes.

@mrjarbenne
Copy link
Member Author

That's perfect. Now I just need to find a way to replace the clunky datepicker in Unpublish with something a bit more user friendly. Maybe this one: https://wordpress.org/plugins/publish-date-datepicker/

@mrjarbenne
Copy link
Member Author

New Issue: https://github.com/hwdsbcommons/HWDSB-Commons/issues/116

Closing this as solved. Looks great.

@mrjarbenne
Copy link
Member Author

With the Announcements Publishing Checklist plugin active, the Slides post type can no longer be scheduled to be published in the future.
2017-09-19_09-39-37

@mrjarbenne mrjarbenne reopened this Sep 19, 2017
@r-a-y
Copy link
Member

r-a-y commented Sep 19, 2017

That's a side effect of using the Publishing Checklist plugin.

You first have to complete all required tasks. In our case, set an Unpublish date and hit "Check Requirements". This should fulfill the requirements and you'll have access to the Publish field again where you can set the publish date into the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants