Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Issues on Dock Element #1

Open
mrjarbenne opened this issue May 15, 2017 · 5 comments
Open

CSS Issues on Dock Element #1

mrjarbenne opened this issue May 15, 2017 · 5 comments

Comments

@mrjarbenne
Copy link
Member

The current code is running here: https://hwdsb.staging.boreal321.com/

I'm using our Revealjs Presentations functionality in place of the content, and I've added some CSS (slidewrapper) to make the slide deck fluid:

https://github.com/hwdsbcommons/DigitalSignage/blob/master/index.php
https://github.com/hwdsbcommons/DigitalSignage/blob/master/style.css#L68

Now the struggle is with the Dock at the bottom, which needs to flow with the slide deck, rather than overlapping the slides on some screen sizes. On smaller screens the Dock seems to disappear entirely.

Aside: Once that is worked out, I can start working on fixed height widgets for things like the Clock and Twitter that was previously rendered in a different way in the ReadMe. The existing theme allowed php to run in the widget area, which I see as a security risk in our environment. If you see other superfluous code while you are poking around feel free to remove. This theme aspired to be a plugin and I've tried to remove that functionality where applicable.

r-a-y added a commit that referenced this issue May 16, 2017
Also helps to position the dock below the <iframe> element.

See #1
@r-a-y
Copy link
Member

r-a-y commented May 16, 2017

Because you are resizing the <iframe> to 100% width, the height becomes variable and the dock needs to take that into account.

This should be addressed in commit b9c0563 (forgot to tag this in the commit message) and aa3265c.

To view, make sure you are logged-in and purge your browser cache. One other thing is the dock height doesn't change if you resize your browser. If you resize your browser, you need to refresh the page in order to see the dock at its rightful place.

r-a-y added a commit that referenced this issue May 16, 2017
Forgot to add this in commit b9c0563.

See #1.
@mrjarbenne
Copy link
Member Author

One other thing is the dock height doesn't change if you resize your browser. If you resize your browser, you need to refresh the page in order to see the dock at its rightful place.

That shouldn't be a big deal. The theme is for Digital Signage, which once running, won't change orientation or viewport size. Thanks for sort this out.

@mrjarbenne
Copy link
Member Author

There still seems to some orientations where the dock falls out side of view. It seems to occur when the browser window is perfectly sized for the slideshow.

2017-05-15_20-54-06

Because of the responsive nature of the Reveal Slideshow, will I always struggle with this?

Would it make more sense to add a sidebar space as well, to better control the aspect ratio of the slideshow, which seems to do well in 4:3 rather than 16:9, in order to keep the dock in view?

2017-05-15_21-00-32

@mrjarbenne mrjarbenne reopened this May 16, 2017
@r-a-y
Copy link
Member

r-a-y commented May 16, 2017

Yes to both questions.

It all depends on what size you are showing this on. If you are showing this on a HD TV or monitor, then you'd need to ensure that the IFRAME is set to 4:3.

@mrjarbenne
Copy link
Member Author

Primarily on an HD TV. I'm trying to recreate the Panic Statusboard app that they have stopped developing (https://panic.com/blog/the-future-of-status-board/), but I'm completely out of my depth.

2017-05-15_21-15-11

Related: Is the IFRAME the best way to do this if I'm trying to pull up /presentation/announcements or is there a better way to call up the presentation within the page template? Perhaps a variation on what the plugin itself uses to render the presentation: https://github.com/hwdsbcommons/reveal-js-presentations/blob/master/templates/taxonomy-presentation.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants