Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Production Version #2

Open
mrjarbenne opened this issue Mar 6, 2023 · 4 comments
Open

Update Production Version #2

mrjarbenne opened this issue Mar 6, 2023 · 4 comments

Comments

@mrjarbenne
Copy link
Member

A few users have reported 503 errors when attempting to authenticate. The version we have running on prod is still calling the deprecated Azure AD Graph, rather than the Microsoft Graph changes made here:

905db3a

It might be good to update this process. We do have some custom scripts at play so I'm hesitant to pull in the update without testing a bit more thoroughly. @r-a-y anything you see as being potential issues?

@r-a-y
Copy link
Member

r-a-y commented Mar 6, 2023

Do you know if we registered a legacy Azure app? If so, I would suggest looking at psignoret#220 to see if this might apply to us. That issue is from 2019, so it might not be applicable however one user had to update the API permissions so it would work for them.

As far as customization, we made one change to the plugin here: psignoret#231

I can create a branch with the latest production version merged with our fix and then maybe we can switch to that?

@r-a-y
Copy link
Member

r-a-y commented Mar 6, 2023

I've synced up the latest changes in our userdata-filter branch, so you can use this for the download: https://github.com/hwdsb/aad-sso-wordpress/archive/refs/heads/userdata-filter.zip

@mrjarbenne
Copy link
Member Author

Ok. I've got Dan checking to see which app type we created. I'm assuming it's a Legacy app. The reports are sporatic, but the new app may be able to handle more authentications simultaneously.

@mrjarbenne
Copy link
Member Author

It was an Azure Graph, not Microsoft Graph. We are going to create a new app and tether it to the updated plugin you shared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants