-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Production Version #2
Comments
Do you know if we registered a legacy Azure app? If so, I would suggest looking at psignoret#220 to see if this might apply to us. That issue is from 2019, so it might not be applicable however one user had to update the API permissions so it would work for them. As far as customization, we made one change to the plugin here: psignoret#231 I can create a branch with the latest production version merged with our fix and then maybe we can switch to that? |
I've synced up the latest changes in our userdata-filter branch, so you can use this for the download: https://github.com/hwdsb/aad-sso-wordpress/archive/refs/heads/userdata-filter.zip |
Ok. I've got Dan checking to see which app type we created. I'm assuming it's a Legacy app. The reports are sporatic, but the new app may be able to handle more authentications simultaneously. |
It was an Azure Graph, not Microsoft Graph. We are going to create a new app and tether it to the updated plugin you shared. |
A few users have reported 503 errors when attempting to authenticate. The version we have running on prod is still calling the deprecated Azure AD Graph, rather than the Microsoft Graph changes made here:
905db3a
It might be good to update this process. We do have some custom scripts at play so I'm hesitant to pull in the update without testing a bit more thoroughly. @r-a-y anything you see as being potential issues?
The text was updated successfully, but these errors were encountered: