Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially retain non-alphanumeric punctuation in filenames #53

Open
rokibhasansagar opened this issue Dec 12, 2023 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@rokibhasansagar
Copy link

Any non-alphanumeric punctuation are being discarded as of now

When downloading a manga through the app, if there are any punctuation (like : or ' etc. ), in the Manga's Title or Chapter's Title, they are just replaced with a white-space.

It would be good if the formatting for naming images/cbz/folder should've retained some of the punctuation to make it look more readable.

Consider this for example: https://mangaplus.shueisha.co.jp/titles/100248

Manga Name: Nue's Exorcist, but it results as Nue S Exorcist
For Chapter's names: : are deleted and ' are replaced by a white-space

What should be done?

  • Just delete any ' (So that the manga title should be Nues Exorcist at least)
  • For chapters, replace : with - along with previous fix
    • Chapter 23: Nue's Candidate is saved with Chapter 23 Nue s Candidate, it should be Chapter 23 - Nues Candidate

If these can be implemented, please do so 🙏🏼

@rokibhasansagar rokibhasansagar added the enhancement New feature or request label Dec 12, 2023
@rokibhasansagar
Copy link
Author

After many attempts, I have modified my code for fixing this to fit my purpose.

It also adds the Publication year and Group name to the filename.

Now, Chapter 1: Portrait view of the sky is saved as Nue's Exorcist/Nue's Exorcist - c001 (2023) (web) [Chapter 1 - Portrait View Of The Sky] [fr3akyphantom].cbz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants