-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ui fix for labels of sidebarNavItem #921
base: main
Are you sure you want to change the base?
Conversation
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Hey there, the underline seems to be spanning beyond the word by a character! |
hey, There is two options to get rid of the whitespace after the text which are the following:
// ...
>
<span class="-me-1">{item.title}</span>
{#if item.label}
// ....
// ....
>
{item.title}{#if item.label}
<span
class="ml-2 inline-block self-center rounded-md bg-[#adfa1d] px-1.5 py-0.5 text-xs leading-none text-[#000000]"
>
// .... I quote from a website: Which solutions do you think are more suitable in this situation? |
The space is fine, we just don't want it underlined. If we wrap the title in a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The labels of sidebarNavItem were erroneously displaying underlines despite having the no-underline class applied.
The no-underline class alone was not affecting the span element's style as expected. This is because the text-decoration property was being inherited from the parent element. By setting the display property of the label to "inline-block", we prevent it from inheriting the underline style when the anchor is hovered over.
before
after