Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Home and Line Chart icons in Blocks Dashboards #1212

Closed
3 tasks
asdromundo opened this issue Jul 25, 2024 · 2 comments · Fixed by #1298
Closed
3 tasks

Wrong Home and Line Chart icons in Blocks Dashboards #1212

asdromundo opened this issue Jul 25, 2024 · 2 comments · Fixed by #1298
Labels
status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation type: documentation A change or addition to the documentation

Comments

@asdromundo
Copy link

asdromundo commented Jul 25, 2024 •
edited
Loading

Change Type

Cleanup (formatting, typos, etc.)

Proposed Changes

The Block code for some of the dashboards contain icons mislabeled (or not longer called that in lucide-svelte).

They can be updated their current name:

Captura de pantalla 2024-07-25 040408

image

ToDo:
Update House and ChartLine icons in dashboards:
@asdromundo asdromundo added the type: documentation A change or addition to the documentation label Jul 25, 2024
@huntabyte huntabyte added the status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation label Jul 30, 2024
thebjorn added a commit to thebjorn/shadcn-svelte that referenced this issue Aug 22, 2024
@thebjorn
Possible fix for issue Wrong Home and Line Chart icons in Blocks Dash…
aa21a99 
…boards huntabyte#1212
@vwkd
Copy link
Contributor

vwkd commented Oct 4, 2024 •
edited
Loading

+1 The Block code snippets are currently broken if one installs lucide by following their docs to the latest version.

It seems shadcn-svelte still uses lucide ^0.363.0.

@huntabyte
Copy link
Owner

Willing to accept a PR to update these in the project!

@vwkd vwkd mentioned this issue Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation type: documentation A change or addition to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix renamed lucide icons vwkd/shadcn-svelte
3 participants
@asdromundo @vwkd @huntabyte