Swift 6 and Hummingbird Postgres

[thoven87]

I know Swift 6 isn't stable yet.

I noticed the following behavior with the latest version of Hummingbird Postgres

The following will produce warning and causes what looks like a memory leak:

WARNING message
Sending 'self'-isolated value of type '[PostgresMigrationGroup]' with later accesses to actor-isolated context risks causing data races; this is an error in the Swift 6 language mode

    app.beforeServerStarts {
        try await postgresMigrations.apply(client: postgresClient, logger: logger, dryRun: false)
    }

Memory will grow until the server is restarted.

Disabling the Postgres migration, the application stays steady at 6mb until traffic starts following.

Swift version
swift-driver version: 1.112.3 Apple Swift version 6.0 (swiftlang-6.0.0.6.8 clang-1600.0.23.1) Target: arm64-apple-macosx15.0

[adam-fowler]

The warning message isn't about memory leaks. It's about accessing memory from multiple tasks. In theory it shouldn't be an issue and I understood the compiler diagnostic should get resolved before Swift 6 was released but I may have to re-visit this.

There was a possible memory leak reported in PostgresNIO just the other day. https://discord.com/channels/431917998102675485/448584561845338139/1267793957153407068

[thoven87]

It's indeed a PostgresNIO memory leak issue. I pinned PostgresNIO to version 1.21.6 and the service memory stayed constant. Thanks @adam-fowler it looks an issue was created for the memory leak issue in Postgres here already.

[thoven87]

The warning message isn't about memory leaks. It's about accessing memory from multiple tasks. In theory it shouldn't be an issue and I understood the compiler diagnostic should get resolved before Swift 6 was released but I may have to re-visit this.

There was a possible memory leak reported in PostgresNIO just the other day. https://discord.com/channels/431917998102675485/448584561845338139/1267793957153407068

Should I leave this issue open for the warning in swift 6?

[adam-fowler]

No we'll keep it open. I've also transferred it to hummingbird-postgres repo

[thoven87]

Is this still needed since PR was just merged?