Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding an expiry window #12

Open
ben-axnick opened this issue Feb 13, 2017 · 1 comment
Open

Adding an expiry window #12

ben-axnick opened this issue Feb 13, 2017 · 1 comment

Comments

@ben-axnick
Copy link
Contributor

One thing I don't like about debouncing is that it's possible to reschedule indefinitely if the rate of operations is too high.

It'd be nice to be able to specify something along the lines of sidekiq_options debounce: {max_seconds: 300}, and then have a check to prevent rescheduling past created_at + max_seconds.

Is this something you feel fits within the gem functionality, or a better fit to handle somewhere else? If the former, I'm happy to write the PR that adds the functionality.
@NuckChorris
Copy link
Member

I actually really like that idea, it seems like a reasonable addition to this 👍 PR welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NuckChorris @ben-axnick