-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change conversation height calculation from Javascript to CSS #406
Comments
@luke- would you accept such a PR? |
See humhub/humhub#7131 for the CSS height calculation of |
@marc-farre Thanks, looks good for me. @yurabakhtin Can you please check? |
@yurabakhtin I'll send a PR so you can test the changes, but after creating the So, this PR will change HumHub minimum version to HumHub 1.17. |
The conversation HTML element height is calculated in real time with JavaScript:
With this function: https://github.com/humhub/mail/blob/master/resources/js/humhub.mail.ConversationView.js#L378-L404
This function could be removed if we have the following LESS code:
For testing, we need to overwrite existing LESS code which should be removed:
Benefits:
height: calc(100vh - 165px);
This would solve the issue we currently have with the Clean Theme on mobile, where the bottom bar is displayed on top of the reply form.
The text was updated successfully, but these errors were encountered: