Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration Settings #2

Open
ArchBlood opened this issue Nov 9, 2023 · 4 comments · May be fixed by #3
Open

Configuration Settings #2

ArchBlood opened this issue Nov 9, 2023 · 4 comments · May be fixed by #3
Labels
enhancement New feature or request

Comments

@ArchBlood
Copy link

Currently I see that the module is very basic and has no configuration settings for admins to enter their information from the backend.

Is there any plans on implementing this or would you like a p/r for this?
@luke-
Copy link
Contributor

luke- commented Nov 9, 2023

There are currently no plans. But you are welcome to contribute a PR.

An implementation according to the following boiler plate would be great
https://community.humhub.com/s/module-development/wiki/Module+Configuration

@luke- luke- added the enhancement New feature or request label Nov 9, 2023
@ArchBlood
Copy link
Author

There are currently no plans. But you are welcome to contribute a PR.

An implementation according to the following boiler plate would be great https://community.humhub.com/s/module-development/wiki/Module+Configuration

With the loadBySettings option, would both getSerialized & setSerialized be possible for tokens?

I'm currently familiar with the following methods;

https://github.com/GreenMeteor/discord/blob/main/models/ConfigureForm.php#L172-L208

@luke-
Copy link
Contributor

luke- commented Nov 10, 2023

Yes, should be possible with the boilerplate.

@ArchBlood ArchBlood linked a pull request Nov 10, 2023 that will close this issue
Open
@ArchBlood
Copy link
Author

Still needs actual testing as I currently have no way of doing so, but this is a draft of the configuration settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enh: Configuration Settings ArchBlood/jwt-sso
2 participants
@luke- @ArchBlood