Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use _blank on external richtext links #85

Closed
buddh4 opened this issue Apr 10, 2020 · 4 comments
Closed

Only use _blank on external richtext links #85

buddh4 opened this issue Apr 10, 2020 · 4 comments

Comments

@buddh4
Copy link
Contributor

buddh4 commented Apr 10, 2020

Is your feature request related to a problem? Please describe.

All richtext links use a _blank target. We should only use blank target for external links. Somehow we need to detect file links or prevent pjax in certain cases.

@buddh4 buddh4 self-assigned this Apr 10, 2020
@timaschew
Copy link

It's even not possible to explicitly set relative links to /s/my-space or anchors #section-a.

Everytime https:// is prepended automatically.

@ArchBlood
Copy link

It's even not possible to explicitly set relative links to /s/my-space or anchors #section-a.

Everytime https:// is prepended automatically.

See #61

@marc-farre
Copy link
Contributor

marc-farre commented Feb 15, 2023

@luke- Should we close this issue?
However, the fix has not been released yet: https://github.com/humhub/humhub-prosemirror/blob/develop/docs/CHANGELOG.md -> Enh humhub/humhub#61

@luke- luke- transferred this issue from humhub/humhub Feb 16, 2023
@luke-
Copy link
Contributor

luke- commented Feb 16, 2023

@funkycram Let's leave it open until the release, I hope that after v1.14 we can continue to work on that and finally release version 2.0.

@luke- luke- closed this as completed May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants