Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Topic support #103

Closed
spoorun opened this issue Jan 25, 2021 · 6 comments
Closed

Add Topic support #103

spoorun opened this issue Jan 25, 2021 · 6 comments
Assignees

Comments

@spoorun
Copy link

spoorun commented Jan 25, 2021

Currently Topics can be added from the stream to files.

However, when using the Files module itself, a user cannot view, add, delete, edit, or search Topics, nor add them when creating or uploading a file.

@spoorun spoorun changed the title Enable adding viewing and deleting topics within Files Enable topic support within Files Mar 8, 2021
@luke- luke- changed the title Enable topic support within Files Add Topic support Jul 30, 2021
@luke-
Copy link
Contributor

luke- commented Jul 30, 2021

@yurabakhtin The "Topic" field in the 'Edit' dialog of a file (right click / context menu) would be cool.

@yurabakhtin
Copy link
Contributor

@luke- PR #124:

file_topics

@spoorun
Copy link
Author

spoorun commented Aug 8, 2021

Great

Will this mean that a topic can be added during the process uploading or creating a file?

Will topics be viewable/sortable when viewing file list on the files module?

@luke-
Copy link
Contributor

luke- commented Aug 9, 2021

@yurabakhtin Please see my review. I can reproduce the test error on my machine.
@spoorun No, as in other modules, the topics will only be available via the stream for the moment.

@yurabakhtin
Copy link
Contributor

@luke-

Please see my review. I can reproduce the test error on my machine.

Thanks for the comment, it helped. Fixed in PR #124.

@luke- luke- closed this as completed Aug 10, 2021
@spoorun
Copy link
Author

spoorun commented Aug 11, 2021

See #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants