Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu on hover #100

Closed
luke- opened this issue Nov 18, 2020 · 7 comments
Closed

Add context menu on hover #100

luke- opened this issue Nov 18, 2020 · 7 comments
Assignees

Comments

@luke-
Copy link
Contributor

luke- commented Nov 18, 2020

When hover over a file show a "Sandwich/3 Point menu" as access for context menu options.

The options menu when right-clicking is not intiuitively accessible for many users.

@buddh4
Copy link
Contributor

buddh4 commented Nov 18, 2020

But note, there is no hover on mobile devices.

@spoorun
Copy link

spoorun commented Mar 6, 2021

But note, there is no hover on mobile devices.

On mobile view, show the sandwich/3 point menu next to each file?

@luke-
Copy link
Contributor Author

luke- commented Jul 30, 2021

image

On Mobile we can always show the sandwhich menu?

@yurabakhtin
Copy link
Contributor

@luke- I could implement this only with changes in the core js library humhub.ui.additions.js because there all context menu was hidden on click on any element of document and it was impossible to prevent this action from external module side, so it will works after merging the core PR humhub/humhub#5239.
Changes for this module in PR #128

desktop

On Mobile we can always show the sandwhich menu?
I am not sure what css media we can use to detect mobile devices, probably @media (hover: none) {...}, but I see currently the file browser has many columns are hidden on small screens by style class hidden-xxs, so I decided to apply the same rule to display the icon on small screen:

mobile

@luke-
Copy link
Contributor Author

luke- commented Aug 10, 2021

@yurabakhtin ok, great. Then lets postpone this issue until v1.10 when core changes are neccessary. Probably this could also related: #127

@yurabakhtin
Copy link
Contributor

@luke- Min version is updated in commit c228009.

Probably this could also related: #127

I wrote a question but I don't think the task is related, I mean it can be done in separate PR.

@luke-
Copy link
Contributor Author

luke- commented Aug 10, 2021

@yurabakhtin ok! Then lets create a separate PR.

@luke- luke- closed this as completed Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants