-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional menu bar when opening from notification #264
Comments
@felixhahnweilheim Thanks. |
@marc-farre so, the issue occurs when the user clicks on the push notification, right? And we're talking about the kebab menu icon, correct? Additionally, I think Primož is the go-to person here, or are you asking for a solution design-wise? Also, I would like to add that I do not own an Android phone, so I'm unable to test this. The only app I have for iOS is the flavored one, Omrade. 😬 |
It's not easy to reproduce on my side, so not all the time.
yes, the part you highlighted on the screenshot.
@PrimozRatej will answer better for the available solutions, but I was thinking about a way to remove this menu in all cases, not depending on some conditions. |
Regarding that menu, yes, I would also remove it if it is useless (I don't know if we use it in some scenario for something?), as it just takes up screen real estate to add a few options, some of which don't even work. |
This shouldn't happen; it is a bug. This bar is added only on the SSO auth redirect (so the user can close the SSO popup) and should not be added to the actual instance. However, I can't seem to replicate the error. I also tested it with LinkedIn SSO login; the redirect to the end instance does not show this extra header navigation bar. My demo instance (Logged in with SSO + opened from push): Felix development instance (pass/username login): @felixhahnweilheim could you please share how did you came to this state, does this only happen when opening from push notification? |
It only happens with push notification and so far only with the HumHub community |
And I am logged in normally with username and password, no SSO |
Today I got 2 notifications from the HumHub community and it didn't happen anymore. So from my side this issue could be closed. |
@felixhahnweilheim Thanks for your feedback. |
In the HumHub Community, the "Switch Network" button also disappeared, so maybe this is connected? Actually I would say the app should block instances that don't have the "Switch Network" option. It would make sure users never get stuck (and maybe even have to empty the app cache manually). Maybe there should even be a mechanism when a HumHub instance is stuck (e.g. custom JS that has errors), after a while the app goes back to the start screen (with a failure notice) or asks the user how to proceed. I'm just sharing a few thoughts, I did not dig into the code what's already done and what would be possible. |
I keep finding bugs:
I got a new content notification from community.humhub.com and opened it. It correctly opens the app but with an additional menu bar
The options were "Go back", "Go forward", "Share", "Close"
Share seems to work
Close only leaves a blank page
I didn't try the others
But all in all I think this menu bar should not sppear at all. (although the share option would be good to have in general)
The text was updated successfully, but these errors were encountered: