Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin skips adding and committing paths containing special characters #8

Open
hughbris opened this issue May 17, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@hughbris
Copy link
Owner

hughbris commented May 17, 2022

Noticed this when committing a file with this kind of path:

"pages/40.recipes/20.hot-smoked-salmon-salad-chermoula-dressing-saut\303\251ed-limes/recipe.md"

Accented characters are escaped in git listing and path is quoted, thereby avoiding any path filters configured in YAML (I have just [ "pages" ]).

Starting solution would be to match paths starting with quotes as well. Not sure if there are other edge cases that make adding regex support worthwhile.

@hughbris hughbris added the bug Something isn't working label May 17, 2022
@hughbris
Copy link
Owner Author

Thinking for another minute(!), I think the problem might be in the commit string, since the path matches for display purposes 🤷

@hughbris hughbris changed the title Plugin skips adding and committing paths containgin special characters Plugin skips adding and committing paths containing special characters May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant