Skip to content

Commit c98ea02

Browse files
committed
value_model can't be None, so it shouldn't be Optional or have default None
1 parent d625c55 commit c98ea02

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

trl/trainer/ppo_trainer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def __init__(
107107
ref_model: Optional[nn.Module],
108108
reward_model: nn.Module,
109109
train_dataset: Dataset,
110-
value_model: Optional[nn.Module] = None,
110+
value_model: nn.Module,
111111
data_collator: Optional[DataCollatorWithPadding] = None,
112112
eval_dataset: Optional[Union[Dataset, dict[str, Dataset]]] = None,
113113
# less commonly used

0 commit comments

Comments
 (0)