Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluators for specific tasks #34

Open
IlyasMoutawwakil opened this issue Aug 21, 2023 · 5 comments
Open

Evaluators for specific tasks #34

IlyasMoutawwakil opened this issue Aug 21, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@IlyasMoutawwakil
Copy link
Member

IlyasMoutawwakil commented Aug 21, 2023

@regisss would it make sense to add task specific evaluators. for example with automatic-speech-recognition, as I did it manually when I did whisper's benchmark.

@regisss
Copy link
Collaborator

regisss commented Aug 21, 2023

Sure why not!
Do you have task-specific perf metrics in mind? What was the one you used for the Whisper benchmark?

@IlyasMoutawwakil
Copy link
Member Author

WER (word error rate), not very universal, but it's the current standard.

@regisss
Copy link
Collaborator

regisss commented Aug 21, 2023

Ah yes okay, I thought you were talking about some specific speed metrics.
Maybe you can use evaluate for this: https://github.com/huggingface/evaluate

@IlyasMoutawwakil
Copy link
Member Author

IlyasMoutawwakil commented Aug 28, 2023

coool there's already a list of implemented evaluators, including automatic-speech-recognition.
now the question is whether to have use this as a separate benchmark called evaluation or have it as an argument in inference like memory. I think the second makes sense and avoids repeating the same load/optimization/quantization workload.

@regisss
Copy link
Collaborator

regisss commented Aug 28, 2023

I agree, the latter seems better from a UX point of view 👍

@IlyasMoutawwakil IlyasMoutawwakil self-assigned this Nov 3, 2023
@IlyasMoutawwakil IlyasMoutawwakil added the enhancement New feature or request label Nov 3, 2023
@IlyasMoutawwakil IlyasMoutawwakil added the good first issue Good for newcomers label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants