Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential harmonization possible. #1217

Open
Narsil opened this issue Nov 22, 2022 · 1 comment
Open

Potential harmonization possible. #1217

Narsil opened this issue Nov 22, 2022 · 1 comment

Comments

@Narsil
Copy link
Contributor

Narsil commented Nov 22, 2022

Is your feature request related to a problem? Please describe.

Discussion and CommitInfo declare two things which seem the same with different names num and pr_num.

Describe the solution you'd like

Harmonizing would feel better. (Don't care which one)

Unless I am missing an important distinction between the two things that is indeed important.
I am using those values to create the URL (which is included in CommitInfo, but not in Discussion, so I had the same code to create the urls.

@Wauplin
Copy link
Contributor

Wauplin commented Nov 22, 2022

Agree with you. Wouldn't hurt to have some harmonization here :)
Small difference though: pr_num is specifically a PR. The num is related to a discussion so can be Discussion or PR. Still agree on harmonizing.

@Wauplin Wauplin added this to the v0.12 milestone Nov 24, 2022
@Wauplin Wauplin removed this from the v0.12 milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants