Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify test code where a dataset is set as gated #3063

Open
severo opened this issue Sep 18, 2024 · 1 comment
Open

Simplify test code where a dataset is set as gated #3063

severo opened this issue Sep 18, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers refactoring / architecture tests

Comments

@severo
Copy link
Collaborator

severo commented Sep 18, 2024

[email protected] provides an API to set a repository as gated.

We had included a custom version of update_repo_settings because it lacked a gated parameter. Now we can switch back to the huggingface_hub method

dataset-viewer/jobs/cache_maintenance/tests/utils.py

Line 41 in 4859100

def update_repo_settings(

dataset-viewer/services/admin/tests/fixtures/hub.py

Line 24 in 4859100

def update_repo_settings(

dataset-viewer/services/worker/tests/fixtures/hub.py

Line 35 in 4859100

def update_repo_settings(

@severo severo added refactoring / architecture dependencies Pull requests that update a dependency file good first issue Good for newcomers tests labels Sep 18, 2024
@severo
Copy link
Collaborator Author

severo commented Sep 18, 2024

depends on #3064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers refactoring / architecture tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@severo