Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency and Handling Issues with Environment Variable Values (.env) #1380

Open
calycekr opened this issue Jul 31, 2024 · 1 comment
Open

Consistency and Handling Issues with Environment Variable Values (.env) #1380

calycekr opened this issue Jul 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@calycekr
Copy link

Consistency and Handling Issues with Environment Variable Values

  1. The values are either 0 or 1, or false or true.

  2. The values of environment variables are treated as strings, but in the code, they are used as if they were booleans. For example, LLM_SUMMARIZATION=true is actually input as "true", but code like if (!env.LLM_SUMMARIZATION) is used.
@calycekr calycekr changed the title Consistency and Handling Issues with Environment Variable Values Consistency and Handling Issues with Environment Variable Values in .env Jul 31, 2024
@calycekr calycekr changed the title Consistency and Handling Issues with Environment Variable Values in .env Consistency and Handling Issues with Environment Variable Values (.env) Jul 31, 2024
@nsarrazin nsarrazin added the enhancement New feature or request label Jul 31, 2024
@nsarrazin
Copy link
Collaborator

Approved #1379 regarding that one var, but let me know if others also have this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@calycekr @nsarrazin