-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional comments on draft circulated to collaborators on May 6 #66
Comments
eahowerton
added a commit
that referenced
this issue
May 8, 2024
eahowerton
added a commit
that referenced
this issue
May 8, 2024
eahowerton
added a commit
that referenced
this issue
May 8, 2024
eahowerton
added a commit
that referenced
this issue
May 8, 2024
eahowerton
added a commit
that referenced
this issue
May 8, 2024
eahowerton
added a commit
that referenced
this issue
May 8, 2024
eahowerton
added a commit
that referenced
this issue
May 8, 2024
eahowerton
added a commit
that referenced
this issue
May 8, 2024
I've addressed most of these issues. A few follow up notes:
|
(1) I can manually force tables to be only on one page if we prefer this (I do agree it looks cleaner), but note that I have also not found a way to do this otherwise. (4) I can take care of moving this to somewhere in section 5 since I agree it does belong there more than in section 4. |
lshandross
added a commit
that referenced
this issue
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The paper looks great! I have a series of small comments, none of which I really see as essential or should hold up submission, but these are more minor details that I think would make it all just a bit tighter.
simple_ensemble()
call are not appropriately indented in section 5.1. The lines with weights, agg_fun and model_id should start a few spaces in. This is what they look like now in the manuscriptThe text was updated successfully, but these errors were encountered: