Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cpts): refactor cpts project resource to general code style #6227

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

deer-hang
Copy link
Contributor

@deer-hang deer-hang commented Jan 20, 2025

What this PR does / why we need it:

refactor cpts project resource to general code style.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/cpts' TESTARGS='-run TestAccProject_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cpts -v -run TestAccProject_basic -timeout 360m -parallel 4
=== RUN   TestAccProject_basic
--- PASS: TestAccProject_basic (14.25s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cpts      14.296s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      image

@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Jan 20, 2025
@github-ci-robot github-ci-robot merged commit ffa298b into huaweicloud:master Jan 20, 2025
17 checks passed
@deer-hang deer-hang deleted the refactor-cpts-project branch January 21, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm refactor size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants