Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a line editor for filter and search strings #1212

Open
fasterit opened this issue Mar 29, 2023 · 6 comments
Open

Create a line editor for filter and search strings #1212

fasterit opened this issue Mar 29, 2023 · 6 comments
Labels
new feature Completely new feature

Comments

@fasterit
Copy link
Member

fasterit commented Mar 29, 2023

Features required as per #1201:
[ ] cursor movement
[ ] inline scrolling
[ ] dynamic allocation of the text buffer (optional)
[ ] Unicode handling (multi-byte string support)

Can also be used for tab ("Screens") naming

@fasterit fasterit added the new feature Completely new feature label Mar 29, 2023
@BenBE
Copy link
Member

BenBE commented Mar 29, 2023

[ ] Unicode handling (multi-byte string support)

@fasterit
Copy link
Member Author

Added that to the list at the top. In case we get more feature discussion we can then more easily maintain a canonical list.

@natoscott
Copy link
Member

natoscott commented Mar 29, 2023

If it helps, redis(-cli) uses this embedded C library for line editing - works well in my experience, may provide a starting point here. Pretty sure it'd need work to handle Unicode, but perhaps some code/ideas can be used at least.

https://github.com/antirez/linenoise

@fasterit
Copy link
Member Author

We could do a fork based on antirez/linenoise#187

@Explorer09
Copy link
Contributor

What is "inline scrolling" of this feature request?

@BenBE
Copy link
Member

BenBE commented Apr 11, 2023

What is "inline scrolling" of this feature request?

Imagine an input of 50 chars wide, but the text is 128 characters long. Inline scrolling means you can navigate that edit field (cursor movement support) to make different parts of the string visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Completely new feature
Projects
None yet
Development

No branches or pull requests

4 participants