Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More granularity for error types? #76

Open
DmitrySharabin opened this issue Feb 8, 2025 · 0 comments
Open

More granularity for error types? #76

DmitrySharabin opened this issue Feb 8, 2025 · 0 comments

Comments

@DmitrySharabin
Copy link
Collaborator

DmitrySharabin commented Feb 8, 2025

I have a test that passes, even though I expect it to fail:

{
  run () {
    throw new SyntaxError();
  },
  throws: TypeError,
}

I know that both SyntaxError and TypeError are subclasses of the Error class, and according to our docs and the code we have in our codebase, this test should (and does) pass. But should it?

I found a way to get the granularity I need:

{
  run () {
    throw new SyntaxError();
  },
  throws: (error) => error.constructor === TypeError;
}

Is this the right/expected way to get what I need?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant