Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header file refactor #38

Open
olo2552 opened this issue Aug 11, 2018 · 0 comments
Open

Header file refactor #38

olo2552 opened this issue Aug 11, 2018 · 0 comments
Assignees
@justdzasta
Labels
good first issue refactor Code refacotrring

Comments

@olo2552
Copy link
Collaborator

olo2552 commented Aug 11, 2018 •
edited
Loading

https://github.com/hs3city/hs3city.github.io/blob/ad43120d6dde71371a6c36af10101426db593a19/_includes/header.html#L1

  1. <header> has divity. Remove this <div class="nav">.
  2. GET RID OF INLINE STYLING!
  3. <img class="header__logo" src="/assets/logo_white_small.png" alt="small logo"> has issue with BEM convention. Element shouldn't be named as HTML element. What if we changed <header> for other tag? We had rename two elements instead of one.
  4. For code consistency - a & img should be wrapped multiline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justdzasta justdzasta

Labels
good first issue refactor Code refacotrring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olo2552 @justdzasta