no API calls to pull decisions list after startup

[doums]

Hi, I just spotted that caddy bouncer only makes one API call to pull decisions list (GET /v1/decisions/stream?startup=true), during startup sequence and that's it. After that initial call, there is no other calls made to the API. I'm wondering if this is the intended behavior?
In comparison, cs-firewall-bouncer is calling to /v1/decisions/stream at the regular interval set in its config.

It's like ticker_interval value is not used at all.

This is the crowdsec block I use in Caddyfile

  crowdsec {
    api_url http://host.docker.internal:8080
    api_key xxx
    ticker_interval 15s
    # disable_streaming
    # enable_hard_fails
  }
  order crowdsec first

Note: If I run in no-streaming mode (enabling disable_streaming) caddy calls the API as expected for each received request.

[hslatman]

Hey @doums, thank you for reporting this! Apparently the context for the background retrieval was cancelled too early, resulting in only the first retrieval working. I think I may have introduced that bug in the previous release, when I also upgraded the https://github.com/crowdsecurity/go-cs-bouncer library, and failed to properly check the runtime to continue running with the new logic.

I've fixed the issue as part of #23. I've also created a new release with the fix: https://github.com/hslatman/caddy-crowdsec-bouncer/releases/tag/v0.5.0.

I've tested the new upgrades and the fix more extensively, and am working on some proper end-to-end tests to prevent this issue from happening in the future.

[doums]

Happy helping to find bugs, and thanks for the quick fix ;)

edit yup works well now