standarize branch protection rules

[amanmdesai]

repositories have different branch protection rules, some are protected whereas some are not protected.

Instructions

Thanks for contributing! ❤️

If this issue is about a specific episode within a lesson, please provide its link or filename.

Keep in mind that lesson maintainers are volunteers and it may take them some time to respond to your contribution.
To ensure that the right people get notified, you can tag some of the last contributors with @githubname.

Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact the HSF training convenors (contacts here).

You may delete these instructions from your issue.

- HSF Training

[klieret]

Needs to be done on a per-repo basis. I've done this for a few...

[amanmdesai]

thank you

[wdconinc]

Can we list here what the branch protection rules should be?

Suggestion:

• Require a pull request before merging
  • Require approvals:
    • Number of required approvals: 1
  • Dismiss stale pull request approvals when new commits are pushed
• Require status checks to pass before merging
• Require conversation resolution before merging

Also, general options, only allow:

• Allow squash merging
  • Default to pull request title and description

[klieret]

I'm against the "only squash merging" and the "dismiss stale PR approvals" TBH.

I personally generally wouldn't make things to restrictive. Requiring PRs as the normal workflow would be great though. And conversation resolution is easy enough.

[wdconinc]

I guess we won't run into long PR commit histories that are unbuildable, so I don't think squash merging is critical.

[stale]

This issue or pull request has been automatically marked as stale because it has not had recent activity. Please manually close it, if it is no longer relevant, or ask for help or support to help getting it unstuck. Let me bring this to the attention of @klieret @wdconinc @michmx for now.

[wdconinc]

https://github.com/organizations/hsf-training/settings/rules/ allows organization rulesets but only for enterprise. Created ruleset, but left it disabled.