Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loaded question: have you considered porting to lua, integrating fully with neovim LSP? #156

Open
coxackie opened this issue Jan 4, 2021 · 5 comments
Labels
feature-request wontfix This will not be worked on

Comments

@coxackie
Copy link

coxackie commented Jan 4, 2021

I know that this is probably not going to go down well, but I guess it is a legitimate inquiry. So here we go:

Neovim has a built-in LSP implementation that is getting quite stable now. VS-code (json) style snippets are the default choice for LSP integration. Which brings the natural question: vsnip can become the de-facto snippet implementation for neovim, especially given its great interoperability with completion-nvim. To do this in the most efficient (in terms of speed) way, an implementation of vsnip in Lua would be the optimal choice.

Any thoughts?

@hrsh7th
Copy link
Owner

hrsh7th commented Jan 4, 2021

I think pure Lua snippet implementation is already exists and nvim comminity accept it with welcoming.

You can see it on here. https://github.com/norcalli/snippets.nvim

@hrsh7th
Copy link
Owner

hrsh7th commented Jan 4, 2021

And I don't care about licensing.
thus anyone can port vsnip to Lua.

Currently, vsnip is large codebase so porting is a hard work. ( it includes tests that very important on vsnip

@coxackie
Copy link
Author

coxackie commented Jan 5, 2021

Yeah, I saw snippets.nvim, but unfortunately it is not "done" or well-documented, and seems abandoned - I hope I am wrong. So, without having looked at the source code yet, if someone wanted to port this in Lua using only integration with completion-nvim and built-in nvim lsp, would it be a huge effort?

@hrsh7th
Copy link
Owner

hrsh7th commented Jan 5, 2021

I hope someone port vim-vsnip to Lua...

The vim-vsnip supports vim and neovim.
And I don't want to maintenance two snippet engine...

I understood and personally agree (because I'm neovim user) but I can't do it for the above reasons.

@coxackie
Copy link
Author

coxackie commented Jan 5, 2021

ok, many thanks, feel free to close this, if you see fit. Or leave it open if you want it to have visibility. Your call.

@hrsh7th hrsh7th added feature-request wontfix This will not be worked on labels Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants