remove non compiling code #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greole
force-pushed
the
refact/remove_non_compiling_code
branch
from
4d75578
to
7d0b1b6
Compare
|
I found some checks failed. Is it okay to fail to build OGL for OpenFOAM? |
yes that is expected for now. We should fix that in a separate PR in this stack. |
greole
force-pushed
the
refact/remove_non_compiling_code
branch
from
99087b6
to
a35359d
Compare
greole
force-pushed
the
refact/remove_non_compiling_code
branch
4 times, most recently
from
9cc2d44
to
86daf4f
Compare
chihta-wang
reviewed
Jun 27, 2024
.github/workflows/static_checks.yaml
Outdated
| - name: Run clang-tidy | ||
| run: | | ||
| git config --global --add safe.directory /__w/OGL/OGL | ||
| # Create list of .cpp files belonging to this repository |
There was a problem hiding this comment.
The comment may need to reflect the change:
# Create list of .C files belonging to this repository
| # Create list of .cpp files that are in this repository and part of the | ||
| # compilation database | ||
| # also filters out " at the begin and end of the filename | ||
| jq ".[] | .file" build/ReleaseAll/compile_commands.json \ | ||
| jq ".[] | .file" build/ReleaseCPUOnly/compile_commands.json \ |
There was a problem hiding this comment.
Does ReleaseAll mean it is for both CPU and GPU?
Why changes to ReleaseCPUOnly?
There was a problem hiding this comment.
No, the ReleaseAll came from the corresponding NeoFOAM workflow and just means build all targets (unit tests, core, ...)
greole
force-pushed
the
refact/remove_non_compiling_code
branch
from
c63140e
to
9f728e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just removes some parts of the code that wont work with ginkgo 1.8.0 it is not meant to produce a working of OGL but rather allows to implement on top of it.