From 641b3090dbe8d3359144b7c07da6c3d26398de46 Mon Sep 17 00:00:00 2001 From: Christoph Thiede Date: Sun, 5 Jan 2025 03:30:10 +0100 Subject: [PATCH] add suspiciousAuthorInitials test --- .../class/defaultFastSelectionTests.st | 2 +- .../class/defaultFullSelectionTests.st | 2 +- .../methodProperties.json | 4 ++-- .../instance/suspiciousAuthorInitials..st | 18 ++++++++++++++++++ .../SLMiscPlugIn.class/methodProperties.json | 1 + .../instance/mapSuspiciousAuthorInitials..st | 7 +++++++ .../methodProperties.json | 1 + 7 files changed, 31 insertions(+), 4 deletions(-) create mode 100644 packages/SwaLint-PlugIns.package/SLMiscPlugIn.class/instance/suspiciousAuthorInitials..st create mode 100644 packages/SwaLintBrowser.package/SL2DefaultTestMapper.class/instance/mapSuspiciousAuthorInitials..st diff --git a/packages/SwaLint-Core.package/SLDefaultDialog.class/class/defaultFastSelectionTests.st b/packages/SwaLint-Core.package/SLDefaultDialog.class/class/defaultFastSelectionTests.st index 6575abab..e34680b9 100644 --- a/packages/SwaLint-Core.package/SLDefaultDialog.class/class/defaultFastSelectionTests.st +++ b/packages/SwaLint-Core.package/SLDefaultDialog.class/class/defaultFastSelectionTests.st @@ -1,4 +1,4 @@ instance-creation defaultFastSelectionTests - ^ { #smallLintUnconditionalRecursion . #instanceVariableAccessIsConsistent: . #collectionProtocolRule: . #smallLintJustSendsSuper . #smallLintTempsReadBeforeWritten . #unnecessaryAssignmentRule: . #smallLintConsistencyCheck . #longMethods: . #smallLintDetectContains . #smallLintToDoWithIncrement . #smallLintEqualNotUsed . #smallLintModifiesCollection . #smallLintOverridesSpecialMessage . #lawOfDemeterRule: . #smallLintAbstractClass . #smallLintCollectSelectNotUsed . #smallLintOnlyReadOrWrittenVariable . #smallLintMethodModifierFinal . #smallLintMissingYourself . #smallLintUndeclaredReference . #smallLintOnlyReadOrWrittenTemporary . #smallLintUsesTrue . #dotAfterReturn: . #smallLintFloatEqualityComparison } asSet \ No newline at end of file + ^ { #smallLintUnconditionalRecursion . #instanceVariableAccessIsConsistent: . #collectionProtocolRule: . #smallLintJustSendsSuper . #smallLintTempsReadBeforeWritten . #unnecessaryAssignmentRule: . #smallLintConsistencyCheck . #longMethods: . #smallLintDetectContains . #smallLintToDoWithIncrement . #smallLintEqualNotUsed . #smallLintModifiesCollection . #smallLintOverridesSpecialMessage . #lawOfDemeterRule: . #smallLintAbstractClass . #smallLintCollectSelectNotUsed . #smallLintOnlyReadOrWrittenVariable . #smallLintMethodModifierFinal . #smallLintMissingYourself . #smallLintUndeclaredReference . #smallLintOnlyReadOrWrittenTemporary . #smallLintUsesTrue . #dotAfterReturn: . #smallLintFloatEqualityComparison. #suspiciousAuthorInitials: } asSet \ No newline at end of file diff --git a/packages/SwaLint-Core.package/SLDefaultDialog.class/class/defaultFullSelectionTests.st b/packages/SwaLint-Core.package/SLDefaultDialog.class/class/defaultFullSelectionTests.st index a914c804..82f61423 100644 --- a/packages/SwaLint-Core.package/SLDefaultDialog.class/class/defaultFullSelectionTests.st +++ b/packages/SwaLint-Core.package/SLDefaultDialog.class/class/defaultFullSelectionTests.st @@ -1,4 +1,4 @@ instance-creation defaultFullSelectionTests - ^ { #smallLintExcessiveArguments . #smallLintEquivalentSuperclassMethods . #smallLintUnclassifiedMethods . #lawOfDemeterRule: . #noClassComments: . #smallLintMissingYourself . #smallLintOnlyReadOrWrittenVariable . #unnecessaryAssignmentRule: . #smallLintBooleanPrecedence . #smallLintAbstractClass . #smallLintMissingSuperSends . #ifTrueReturnsRule: . #smallLintReturnsIfTrue . #smallLintCollectionMessagesToExternalObject . #smallLintConsistencyCheck . #smallLintCollectionCopyEmpty . #smallLintFloatEqualityComparison . #smallLintUnreferencedVariables . #smallLintMethodModifierOverride . #brainMethod: . #smallLintOnlyReadOrWrittenTemporary . #smallLintYourselfNotUsed . #godClass: . #smallLintExcessiveMethods . #magicNumbers: . #instVarInAllSubclasses: . #collectionProtocolRule: . #smallLintDefinesEqualNotHash . #badlyFormattedMethods: . #smallLintUnconditionalRecursion . #smallLintLiteralArrayContainsComma . #smallLintLiteralArrayContainsDot .#smallLintTempsReadBeforeWritten . #smallLintMissingSubclassResponsibility . #instanceVariableAccessIsConsistent: . #smallLintEqualNotUsed . #smallLintAddRemoveDependents . #smallLintMethodModifierFinal . #smallLintModifiesCollection . #smallLintRefersToClass . #smallLintThreeElementPoint . #precedenceRule: . #brainClass: . #smallLintCollectSelectNotUsed . #featureEnvy: . #smallLintInconsistentMethodClassification . #smallLintUsesTrue . #smallLintJustSendsSuper . #smallLintDetectContains . #metaProgramming: . #smallLintTemporaryVariableCapitalization . #smallLintAssignmentWithoutEffect . #smallLintOverridesSpecialMessage . #smallLintUndeclaredReference . #smallLintEqualsTrue . #smallLintToDoWithIncrement . #smallLintExcessiveVariables . #longMethods: . #dotAfterReturn: } asSet \ No newline at end of file + ^ { #smallLintExcessiveArguments . #smallLintEquivalentSuperclassMethods . #smallLintUnclassifiedMethods . #lawOfDemeterRule: . #noClassComments: . #smallLintMissingYourself . #smallLintOnlyReadOrWrittenVariable . #unnecessaryAssignmentRule: . #smallLintBooleanPrecedence . #smallLintAbstractClass . #smallLintMissingSuperSends . #ifTrueReturnsRule: . #smallLintReturnsIfTrue . #smallLintCollectionMessagesToExternalObject . #smallLintConsistencyCheck . #smallLintCollectionCopyEmpty . #smallLintFloatEqualityComparison . #smallLintUnreferencedVariables . #smallLintMethodModifierOverride . #brainMethod: . #smallLintOnlyReadOrWrittenTemporary . #smallLintYourselfNotUsed . #godClass: . #smallLintExcessiveMethods . #magicNumbers: . #instVarInAllSubclasses: . #collectionProtocolRule: . #smallLintDefinesEqualNotHash . #badlyFormattedMethods: . #smallLintUnconditionalRecursion . #smallLintLiteralArrayContainsComma . #smallLintLiteralArrayContainsDot .#smallLintTempsReadBeforeWritten . #smallLintMissingSubclassResponsibility . #instanceVariableAccessIsConsistent: . #smallLintEqualNotUsed . #smallLintAddRemoveDependents . #smallLintMethodModifierFinal . #smallLintModifiesCollection . #smallLintRefersToClass . #smallLintThreeElementPoint . #precedenceRule: . #brainClass: . #smallLintCollectSelectNotUsed . #featureEnvy: . #smallLintInconsistentMethodClassification . #smallLintUsesTrue . #smallLintJustSendsSuper . #smallLintDetectContains . #metaProgramming: . #smallLintTemporaryVariableCapitalization . #smallLintAssignmentWithoutEffect . #smallLintOverridesSpecialMessage . #smallLintUndeclaredReference . #smallLintEqualsTrue . #smallLintToDoWithIncrement . #smallLintExcessiveVariables . #longMethods: . #dotAfterReturn:. #suspiciousAuthorInitials: } asSet \ No newline at end of file diff --git a/packages/SwaLint-Core.package/SLDefaultDialog.class/methodProperties.json b/packages/SwaLint-Core.package/SLDefaultDialog.class/methodProperties.json index ef2a0c24..0f620325 100644 --- a/packages/SwaLint-Core.package/SLDefaultDialog.class/methodProperties.json +++ b/packages/SwaLint-Core.package/SLDefaultDialog.class/methodProperties.json @@ -1,8 +1,8 @@ { "class" : { "build" : "NA 7/2/2015 18:31", - "defaultFastSelectionTests" : "BD 6/29/2018 15:56", - "defaultFullSelectionTests" : "ct 12/13/2024 03:19", + "defaultFastSelectionTests" : "ct 1/5/2025 02:28", + "defaultFullSelectionTests" : "ct 1/5/2025 02:23", "lastSelectionTests" : "BD 6/29/2018 14:35", "lastSelectionTests:" : "BD 6/29/2018 15:55", "onEnvironment:" : "LG 7/5/2018 20:26", diff --git a/packages/SwaLint-PlugIns.package/SLMiscPlugIn.class/instance/suspiciousAuthorInitials..st b/packages/SwaLint-PlugIns.package/SLMiscPlugIn.class/instance/suspiciousAuthorInitials..st new file mode 100644 index 00000000..ae133c22 --- /dev/null +++ b/packages/SwaLint-PlugIns.package/SLMiscPlugIn.class/instance/suspiciousAuthorInitials..st @@ -0,0 +1,18 @@ +method tests +suspiciousAuthorInitials: aMethodTestObject + + + | authorInitials suspicious | + aMethodTestObject ifClassTestChildrenWith: #suspiciousAuthorInitials:. + aMethodTestObject shouldBeMethod. + authorInitials := aMethodTestObject testObject timeStamp ifNotNil: [:stamp | + stamp findTokens at: 1 ifAbsent: nil]. + + suspicious := authorInitials isEmptyOrNil not and: + [(authorInitials copyWithout: '0123456789/') isEmpty + or: [#('programmatic' 'smalltalkCI' '*test*') anySatisfy: [:pattern | pattern match: authorInitials]]]. + + ^ (self booleanResult: suspicious) + showOnlyIfTrue \ No newline at end of file diff --git a/packages/SwaLint-PlugIns.package/SLMiscPlugIn.class/methodProperties.json b/packages/SwaLint-PlugIns.package/SLMiscPlugIn.class/methodProperties.json index 4d7ca3ac..38ea779b 100644 --- a/packages/SwaLint-PlugIns.package/SLMiscPlugIn.class/methodProperties.json +++ b/packages/SwaLint-PlugIns.package/SLMiscPlugIn.class/methodProperties.json @@ -26,6 +26,7 @@ "methodWidth:" : "JTM 5/27/2015 11:16", "miscTest:" : "AT 5/8/2008 09:38", "printOn:" : "NH 6/24/2015 14:11", + "suspiciousAuthorInitials:" : "ct 1/5/2025 02:54", "usedForeignVars:" : "JTM 5/27/2015 11:17", "usedInstVars:" : "JTM 5/27/2015 11:17", "usedVars:" : "JTM 5/27/2015 11:17" } } diff --git a/packages/SwaLintBrowser.package/SL2DefaultTestMapper.class/instance/mapSuspiciousAuthorInitials..st b/packages/SwaLintBrowser.package/SL2DefaultTestMapper.class/instance/mapSuspiciousAuthorInitials..st new file mode 100644 index 00000000..4e66b19f --- /dev/null +++ b/packages/SwaLintBrowser.package/SL2DefaultTestMapper.class/instance/mapSuspiciousAuthorInitials..st @@ -0,0 +1,7 @@ +map - 2. code quality - metadata +mapSuspiciousAuthorInitials: aSLTestData + + + ^ (self makeTestFrom: aSLTestData) + addCategoryPath: #('code quality' 'metadata'); + yourself \ No newline at end of file diff --git a/packages/SwaLintBrowser.package/SL2DefaultTestMapper.class/methodProperties.json b/packages/SwaLintBrowser.package/SL2DefaultTestMapper.class/methodProperties.json index 7d4c07f9..92a4b206 100644 --- a/packages/SwaLintBrowser.package/SL2DefaultTestMapper.class/methodProperties.json +++ b/packages/SwaLintBrowser.package/SL2DefaultTestMapper.class/methodProperties.json @@ -125,6 +125,7 @@ "mapStringConcatenation:" : "ct 12/19/2024 01:55", "mapSubclassResponsibilityNotImplemented:" : "ct 12/18/2024 23:56", "mapSuperSendsNew:" : "ct 12/19/2024 02:29", + "mapSuspiciousAuthorInitials:" : "ct 1/5/2025 02:36", "mapSystemLocCount:" : "ct 12/19/2024 05:38", "mapSystemMethodCount:" : "ct 12/19/2024 05:38", "mapTemporaryVariableCapitalization:" : "ct 12/19/2024 04:14",