Skip to content

Commit da3b79c

Browse files
committed
Changes to books
add more asd
1 parent 323dd56 commit da3b79c

File tree

41 files changed

+34
-49
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+34
-49
lines changed

patches/server/0060-Allow-disabling-component-selector-resolving-in-book.patch

-30
This file was deleted.

patches/server/0067-Add-config-option-for-logging-player-ip-addresses.patch patches/server/0066-Add-config-option-for-logging-player-ip-addresses.patch

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ Subject: [PATCH] Add config option for logging player ip addresses
55

66

77
diff --git a/src/main/java/com/hpfxd/pandaspigot/config/PandaSpigotConfig.java b/src/main/java/com/hpfxd/pandaspigot/config/PandaSpigotConfig.java
8-
index 8d071fdd1ae8aaa97003f0b56d7e206e6dd4b44f..ae3cdaca275b1a50c5c37c3dd0021c4bd579d373 100644
8+
index fcf7738c75f21ad23693d903b476c65b4a207a84..1d8e4d1050ebafef8784920481621965fd5c212f 100644
99
--- a/src/main/java/com/hpfxd/pandaspigot/config/PandaSpigotConfig.java
1010
+++ b/src/main/java/com/hpfxd/pandaspigot/config/PandaSpigotConfig.java
11-
@@ -121,4 +121,8 @@ public class PandaSpigotConfig {
11+
@@ -119,4 +119,8 @@ public class PandaSpigotConfig {
12+
"https://docs.papermc.io/paper/reference/paper-global-configuration#packet-limiter\n" +
13+
"(note that \"max-packet-rate\" is renamed to \"maxPacketRate\")")
1214
public PacketLimiterConfig packetLimiter = PacketLimiterConfig.createDefault();
13-
14-
public boolean resolveSelectorsInBooks = true;
1515
+
1616
+ @Comment("Whether player IP addresses should be logged by the server. This does not impact\n" +
1717
+ "the ability of plugins to log the IP addresses of players.")

patches/server/0070-Fix-AIOOBE-in-inventory-handling.patch patches/server/0069-Fix-AIOOBE-in-inventory-handling.patch

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Subject: [PATCH] Fix AIOOBE in inventory handling
55

66

77
diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java
8-
index 15f7c315df23eac08e12ce752b1b1bb23fd25aba..557bb0d99b227ed0a70b1855f9ddab88f94dc134 100644
8+
index 977675f6155a1ccb1d9cdfdcb48a9f922805df9a..1f80521c97fd7b0ef263b9e17cb79bcc51db0433 100644
99
--- a/src/main/java/net/minecraft/server/PlayerConnection.java
1010
+++ b/src/main/java/net/minecraft/server/PlayerConnection.java
1111
@@ -1600,7 +1600,7 @@ public class PlayerConnection implements PacketListenerPlayIn, IUpdatePlayerList

patches/server/0073-Add-World-Util-Methods.patch patches/server/0072-Add-World-Util-Methods.patch

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ index 03fe76355813497a5db33ad185db0e4b40c6f85a..df28cca6175ff3ddf4992c44a0760ef1
2020
int j = blockposition.getX() & 15;
2121
int k = blockposition.getY();
2222
diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
23-
index b75d78da71f24a0b02bf709d026389add0556489..56d9a764bbf521f512e959efaa864c445a198917 100644
23+
index 084f107bf019b0f2e00d17a470632780db490abc..a429dc5e950a31557d444d0a50ed71d13f13d555 100644
2424
--- a/src/main/java/net/minecraft/server/World.java
2525
+++ b/src/main/java/net/minecraft/server/World.java
2626
@@ -93,7 +93,7 @@ public abstract class World implements IBlockAccess {

patches/server/0076-Use-less-resources-for-collisions.patch patches/server/0075-Use-less-resources-for-collisions.patch

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ index 58e485c2e5845dda15c33ee1beb170860535f88b..854cf888d64e50bfd85420bb5dcc9386
4242
try {
4343
iblockdata.getBlock().a(this.world, blockposition2, iblockdata, this);
4444
diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
45-
index 870e4f920fc336e38f331699eb0d8d91c43112d8..ad5db898164f575b37fdc9c8800660eded6dc45c 100644
45+
index 46ebdb5e22592658cbd8172390b52edac5344e0f..ba185d2ef2b7970f566aa9c5980dad1e6c80e6f0 100644
4646
--- a/src/main/java/net/minecraft/server/World.java
4747
+++ b/src/main/java/net/minecraft/server/World.java
4848
@@ -296,8 +296,13 @@ public abstract class World implements IBlockAccess {

patches/server/0084-Book-security-improvements.patch patches/server/0083-Book-security-improvements.patch

+25-10
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@ From: uRyanxD <[email protected]>
33
Date: Fri, 9 Dec 2022 13:17:43 -0300
44
Subject: [PATCH] Book security improvements
55

6-
Co-authored-by: RoccoDev
76
Co-authored-by: bob7l
7+
Co-authored-by: RoccoDev <[email protected]>
8+
Co-authored-by: xism4 <[email protected]>
9+
Co-authored-by: linsaftw <[email protected]>
810

911
diff --git a/src/main/java/net/minecraft/server/PacketDataSerializer.java b/src/main/java/net/minecraft/server/PacketDataSerializer.java
1012
index ad33280bb8baab581a4ac17b5fe78022134c676b..a6480484f2c2f55e6cb4ef682c99f56d46980a0e 100644
@@ -20,7 +22,7 @@ index ad33280bb8baab581a4ac17b5fe78022134c676b..a6480484f2c2f55e6cb4ef682c99f56d
2022
}
2123

2224
diff --git a/src/main/java/net/minecraft/server/PlayerConnection.java b/src/main/java/net/minecraft/server/PlayerConnection.java
23-
index 14afdc7cbb88150f4711811a06fa149c36cec8b9..3904c77141ec3b778dc6cc2fd256961b7598ab31 100644
25+
index 1f80521c97fd7b0ef263b9e17cb79bcc51db0433..f5ef763b8783a6a275b5d4311d368bed25e3b878 100644
2426
--- a/src/main/java/net/minecraft/server/PlayerConnection.java
2527
+++ b/src/main/java/net/minecraft/server/PlayerConnection.java
2628
@@ -111,6 +111,7 @@ public class PlayerConnection implements PacketListenerPlayIn, IUpdatePlayerList
@@ -60,10 +62,10 @@ index 14afdc7cbb88150f4711811a06fa149c36cec8b9..3904c77141ec3b778dc6cc2fd256961b
6062

6163
try {
6264
diff --git a/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBook.java b/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBook.java
63-
index 0b5ada0118f521eaca65b0fd67ebf232fa183b1a..8f46643ddcd0365c842384268a92aa475f03a97c 100644
65+
index 0b5ada0118f521eaca65b0fd67ebf232fa183b1a..44b3c3ac151fecebd41b43b7bb6708cb8508dc50 100644
6466
--- a/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBook.java
6567
+++ b/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaBook.java
66-
@@ -33,8 +33,11 @@ public class CraftMetaBook extends CraftMetaItem implements BookMeta {
68+
@@ -33,8 +33,12 @@ public class CraftMetaBook extends CraftMetaItem implements BookMeta {
6769
static final ItemMetaKey BOOK_PAGES = new ItemMetaKey("pages");
6870
static final ItemMetaKey RESOLVED = new ItemMetaKey("resolved");
6971
static final ItemMetaKey GENERATION = new ItemMetaKey("generation");
@@ -72,12 +74,13 @@ index 0b5ada0118f521eaca65b0fd67ebf232fa183b1a..8f46643ddcd0365c842384268a92aa47
7274
+ // PandaSpigot start - Add security limits to books
7375
+ static final int MAX_PAGES = 50;
7476
+ static final int MAX_PAGE_LENGTH = 256;
75-
+ static final int MAX_TITLE_LENGTH = 32;
77+
+ static final int MAX_TITLE_LENGTH = 16;
78+
+ static final int MAX_AUTHOR_LENGHT = 16;
7679
+ // PandaSpigot end
7780

7881
protected String title;
7982
protected String author;
80-
@@ -61,11 +64,11 @@ public class CraftMetaBook extends CraftMetaItem implements BookMeta {
83+
@@ -61,11 +65,11 @@ public class CraftMetaBook extends CraftMetaItem implements BookMeta {
8184
super(tag);
8285

8386
if (tag.hasKey(BOOK_TITLE.NBT)) {
@@ -87,11 +90,11 @@ index 0b5ada0118f521eaca65b0fd67ebf232fa183b1a..8f46643ddcd0365c842384268a92aa47
8790

8891
if (tag.hasKey(BOOK_AUTHOR.NBT)) {
8992
- this.author = limit( tag.getString(BOOK_AUTHOR.NBT), 1024 ); // Spigot
90-
+ this.author = limit( tag.getString(BOOK_AUTHOR.NBT), 16 ); // Spigot // PandaSpigot
93+
+ this.author = limit( tag.getString(BOOK_AUTHOR.NBT), MAX_AUTHOR_LENGHT ); // Spigot // PandaSpigot
9194
}
9295

9396
boolean resolved = false;
94-
@@ -80,7 +83,7 @@ public class CraftMetaBook extends CraftMetaItem implements BookMeta {
97+
@@ -80,7 +84,7 @@ public class CraftMetaBook extends CraftMetaItem implements BookMeta {
9598
if (tag.hasKey(BOOK_PAGES.NBT) && handlePages) {
9699
NBTTagList pages = tag.getList(BOOK_PAGES.NBT, 8);
97100

@@ -100,7 +103,7 @@ index 0b5ada0118f521eaca65b0fd67ebf232fa183b1a..8f46643ddcd0365c842384268a92aa47
100103
String page = pages.getString(i);
101104
if (resolved) {
102105
try {
103-
@@ -90,7 +93,7 @@ public class CraftMetaBook extends CraftMetaItem implements BookMeta {
106+
@@ -90,7 +94,7 @@ public class CraftMetaBook extends CraftMetaItem implements BookMeta {
104107
// Ignore and treat as an old book
105108
}
106109
}
@@ -109,7 +112,7 @@ index 0b5ada0118f521eaca65b0fd67ebf232fa183b1a..8f46643ddcd0365c842384268a92aa47
109112
}
110113
}
111114
}
112-
@@ -104,7 +107,9 @@ public class CraftMetaBook extends CraftMetaItem implements BookMeta {
115+
@@ -104,7 +108,9 @@ public class CraftMetaBook extends CraftMetaItem implements BookMeta {
113116

114117
Iterable<?> pages = SerializableMeta.getObject(Iterable.class, map, BOOK_PAGES.BUKKIT, true);
115118
if(pages != null) {
@@ -119,3 +122,15 @@ index 0b5ada0118f521eaca65b0fd67ebf232fa183b1a..8f46643ddcd0365c842384268a92aa47
119122
if (page instanceof String) {
120123
addPage((String) page);
121124
}
125+
@@ -188,7 +194,10 @@ public class CraftMetaBook extends CraftMetaItem implements BookMeta {
126+
this.title = null;
127+
return true;
128+
} else if (title.length() > MAX_TITLE_LENGTH) {
129+
- return false;
130+
+ // PandaSpigot start
131+
+ this.title = title.substring(0, MAX_TITLE_LENGTH);
132+
+ return true;
133+
+ // PandaSpigot end
134+
}
135+
136+
this.title = title;

patches/server/0090-Backport-ArrowDMG-fix.patch patches/server/0089-Backport-ArrowDMG-fix.patch

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Subject: [PATCH] Backport ArrowDMG fix
66
Upstream commit: PaperMC/Paper@bb397ba74c034ffe5ae164d774a043cb7bca0472
77

88
diff --git a/src/main/java/net/minecraft/server/EntityLiving.java b/src/main/java/net/minecraft/server/EntityLiving.java
9-
index cd95aa17291d31e3cebe9f6488a43923a18facba..94d8f2ffe938bd2d57d0297f9efc43ee55da3ba9 100644
9+
index e8a20bc5b66b4777c1d5de1f0a036db85407766b..62e38bf1c0d0fc878768ac00fa3c56ac7fe5101d 100644
1010
--- a/src/main/java/net/minecraft/server/EntityLiving.java
1111
+++ b/src/main/java/net/minecraft/server/EntityLiving.java
1212
@@ -1300,13 +1300,26 @@ public abstract class EntityLiving extends Entity {

patches/server/0097-Add-SLF4J-implementation.patch patches/server/0096-Add-SLF4J-implementation.patch

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Subject: [PATCH] Add SLF4J implementation
55

66

77
diff --git a/build.gradle.kts b/build.gradle.kts
8-
index 70bfa464fad7080ab5bb60ad2a16aabfc9e039bd..8b91873dbe8355a32351e9939404b390eb05dd64 100644
8+
index bce6429d64fe4dcf10e8fa507f4792b3037acce3..012ab25b96fde290063444b6dfc246d0bda45ea5 100644
99
--- a/build.gradle.kts
1010
+++ b/build.gradle.kts
1111
@@ -24,6 +24,7 @@ dependencies {

0 commit comments

Comments
 (0)