Skip to content

scss deprecation warning in _button-base.scss #663

Open
@WayneYe

Description

@WayneYe

Describe the bug
When i run npm i in my project I saw the following deprecation warnings:

Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

    ┌──> node_modules/@material/button/_button-base.scss
169 │       min-width: 64px;
    │       ^^^^^^^^^^^^^^^ declaration
    ╵
    ┌──> node_modules/@material/elevation/_elevation-theme.scss
329 │ ┌   .mdc-elevation-overlay {
330 │ │     @include feature-targeting.targets($feat-structure) {
331 │ │       @include theme.property(width, $width);
332 │ │       @include theme.property(height, $height);
333 │ │
334 │ │       @if $has-content-sizing {
335 │ │         top: 0;
336 │ │         @include rtl.ignore-next-line();
337 │ │         left: 0;
338 │ │       } @else {
339 │ │         top: 50%;
340 │ │         @include rtl.ignore-next-line();
341 │ │         left: 50%;
342 │ │         transform: translate(-50%, -50%);
343 │ │       }
344 │ │     }
345 │ │   }
    │ └─── nested rule
    ╵
    node_modules/@material/button/_button-base.scss 169:5                   @content
    node_modules/@material/feature-targeting/_feature-targeting.scss 218:5  targets()
    node_modules/@material/button/_button-base.scss 163:3                   -root-structure()
    node_modules/@material/button/_button-base.scss 51:5                    -static-styles-base()
    node_modules/@material/button/_button-base.scss 38:3                    static-styles()
    node_modules/@material/button/_button.scss 84:3                         static-styles-without-ripple()
    node_modules/@material/button/_button.scss 79:3                         static-styles()

To Reproduce
Steps to reproduce the behavior:

  1. In any project uses "@smui/button": "^7.0.0"
  2. Run npm i
  3. Will see the above deprecation warnings

Expected behavior
There should be no deprecation warnings.

Screenshots
N/A.

Desktop (please complete the following information):

  • OS: OSX
  • Browser: N/A
  • Version: v7.0.0

Additional context
Add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions