Skip to content

Commit b8781e9

Browse files
maherouluszczek
authored andcommitted
Fixed some unused variables.
Revised QUICKSTART, Makefiles and configure to take a path and file argument instead of arch=... Fixed the HPCG logo to be "High Performance Conjugate Gradients" (plural). Updated other files for 2.0 release git-svn-id: svn+ssh://software.sandia.gov/svn/hpcg/trunk@228 5e06a57e-6b39-4354-92a0-249a7d0c5410
1 parent 8dd5b44 commit b8781e9

17 files changed

+41
-38
lines changed

Diff for: BUGS

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
==============================================================
22
List of the known problems with the HPCG software
33

4-
Current as of release HPCG - 0.3 - September 25, 2013
4+
Current as of release HPCG - 2.0 - January 28, 2014
55
==============================================================
6-
- Known failure in MPI_Irecv call in ExchangeHalo.cpp when
7-
local_int_t is 'long long' with 4000 MPI processes on the
8-
Sandia system chama. Bug is being explored.
6+
- No known bugs
97

108
==============================================================
119

Diff for: COPYRIGHT

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
======================================================================
22
-- High Performance Conjugate Gradient Benchmark (HPCG)
3-
HPCG - 1.0 - November 19, 2013
3+
HPCG - 2.0 - January 28, 2014
44

55
Michael A. Heroux
6-
Scalable Algorithms Group, Computing Research Division
6+
Scalable Algorithms Group, Computing Research Center
77
Sandia National Laboratories, Albuquerque, NM
88

99
Piotr Luszczek

Diff for: Makefile

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
# -*- Makefile -*-
22

33
# by default, "arch" is unknown
4-
arch = UNKNOWN
4+
#arch = UNKNOWN
5+
#include setup/Make.$(arch)
56

6-
include setup/Make.$(arch)
7+
setup_file = setup/Make.UNKNOWN
8+
include $(setup_file)
79

810
HPCG_DEPS = src/CG.o src/CG_ref.o src/TestCG.o src/ComputeResidual.o \
911
src/ExchangeHalo.o src/GenerateGeometry.o src/GenerateProblem.o \

Diff for: Makefile.ext

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
# -*- Makefile -*-
22

3-
arch = UNKNOWN
3+
#arch = UNKNOWN
4+
setup_file = UNKNOWN
45

5-
include setup/Make.$(arch)
6+
#include setup/Make.$(arch)
7+
include $(setup_file)
68

79

810
HPCG_DEPS = src/CG.o \

Diff for: QUICKSTART

+5-5
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ NOTE: The instructions in this file assume you are working with a version
2121
mkdir My_MPI_OMP_BUILD
2222

2323
3) 'cd' to your build directory, and run the configure command located in the
24-
main hpcg directory, defining the arch argument to be the suffix of your
25-
setup file defined in step 1. Then run 'make'.
24+
main hpcg directory, defining the path and file argument to be the location
25+
of the setup file defined in step 1. Then run 'make'.
2626

2727
Example commands:
2828
cd My_MPI_OMP_BUILD
29-
../configure arch=My_MPI_OMP
29+
../configure ../setup/Make.My_MPI_OMP
3030
make
3131

3232
4) If make is successful, you will have a bin directory containing the files
@@ -46,7 +46,7 @@ NOTE: The instructions in this file assume you are working with a version
4646
the results are valid, and explain how to report them.
4747

4848
Example commands:
49-
less HPCG-Benchmark-0.2_2013:09:25-17:17:52.yaml
50-
mail [email protected] < HPCG-Benchmark-0.2_2013:09:25-17:17:52.yaml
49+
less HPCG-Benchmark-1.1_2014:01:22-22:46:06.yaml
50+
mail [email protected] < HPCG-Benchmark-1.1_2014:01:22-22:46:06.yaml
5151

5252
6) If results are not valid, do not submit them.

Diff for: TODO

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
HPCG - 2.0 - January 28, 2014
44
==============================================================
55

6-
- Add support for TUNING and OFFICIAL execution modes.
76
- Add support for derived MPI Communicators (other than MPI_COMM_WORLD)
87

98
==============================================================

Diff for: TUNING

+6-4
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,16 @@ Sandia National Laboratories; University of Tennessee, Knoxville
3232
* Line 3: This line specifies the local (to an MPI process) dimensions of the
3333
problem. By default, this line reads:
3434

35-
100 100 100
35+
104 104 104
3636

3737
which means that each MPI process will be computing a solution for a cube of
38-
size 100 points.
38+
size 104 points.
3939

4040
* Line 4: This line specifies the number of seconds of how long the timed
4141
portion of the benchmark should run. By default, this line reads:
4242

43-
18000
43+
60
4444

45-
which means that the timed portion of the benchmark will run 5 hours.
45+
which means that the timed portion of the benchmark will run 1 minute.
46+
This length of time is not sufficient for submitting an official run
47+
but does give sufficient data for tuning the benchmark in most cases.

Diff for: bin/hpcg.dat

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
HPCG benchmark input file
22
Sandia National Laboratories; University of Tennessee, Knoxville
3-
100 100 100
4-
3600
3+
104 104 104
4+
60

Diff for: configure

+13-11
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,19 @@ bld_path=`pwd`
55

66
#FIXME: need to check whether src and bld are the same (test f1 -ef f2)
77

8-
if test x"$#" != x"1" -o x`echo "$1" | sed -e 's/arch=..*/arch=/'` != x"arch=" -o x`echo "$1" | sed -e 's/arch=//'` = "x" ; then
9-
echo
10-
echo Please specify '"'arch'"' argument, for example:
11-
echo
12-
echo $0 arch=Unix
13-
echo
14-
exit 127
15-
fi
8+
#if test x"$#" != x"1" -o x`echo "$1" | sed -e 's/arch=..*/arch=/'` != x"arch=" -o x`echo "$1" | sed -e 's/arch=//'` = "x" ; then
9+
# echo
10+
# echo Please specify '"'arch'"' argument, for example:
11+
# echo
12+
# echo $0 arch=Unix
13+
# echo
14+
# exit 127
15+
#fi
1616

17-
arg_arch=`echo "$1" | sed -e 's/arch=//'`
17+
#arg_arch=`echo "$1" | sed -e 's/arch=//'`
1818

19-
setup_file=${src_path}/setup/Make.${arg_arch}
19+
#setup_file=${src_path}/setup/Make.${arg_arch}
20+
setup_file="$1"
2021

2122
if test ! -f $setup_file ; then
2223
echo
@@ -31,7 +32,8 @@ if test -d $mkfile -o -f $mkfile ; then
3132
rm -rf $mkfile
3233
fi
3334

34-
sed -e "s:HPCG_ROOT_PATH:${bld_path}:g" ${src_path}/Makefile.ext | sed -e "s:HPCG_SRC_PATH:${src_path}:g" | sed -e "s:UNKNOWN:${arg_arch}:" > $mkfile
35+
#sed -e "s:HPCG_ROOT_PATH:${bld_path}:g" ${src_path}/Makefile.ext | sed -e "s:HPCG_SRC_PATH:${src_path}:g" | sed -e "s:UNKNOWN:${arg_arch}:" > $mkfile
36+
sed -e "s:HPCG_ROOT_PATH:${bld_path}:g" ${src_path}/Makefile.ext | sed -e "s:HPCG_SRC_PATH:${src_path}:g" | sed -e "s:UNKNOWN:${setup_file}:" > $mkfile
3537

3638
# creating missing directories
3739
for path in src testing bin setup

Diff for: setup/Make.UNKNOWN

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
arch=UNKNOWN
44

5-
VERSION = 1.1
5+
VERSION = 2.0
66

77
UNKNOWN:
88
@echo

Diff for: src/GenerateCoarseProblem.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ void GenerateCoarseProblem(const SparseMatrix & Af) {
6464
}
6565

6666

67-
local_int_t localNumberOfNonzeros = 0;
6867
// TODO: This triply nested loop could be flattened or use nested parallelism
6968
#ifndef HPCG_NOOPENMP
7069
#pragma omp parallel for

Diff for: src/ReportResults.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ void ReportResults(const SparseMatrix & A, int numberOfMgLevels, int numberOfCgS
8282
double fnops_precond = 0.0;
8383
const SparseMatrix * Af = &A;
8484
for (int i=1; i<numberOfMgLevels; ++i) {
85-
double fnrow_Af = Af->totalNumberOfRows;
8685
double fnnz_Af = Af->totalNumberOfNonzeros;
8786
double fnumberOfPresmootherSteps = Af->mgData->numberOfPresmootherSteps;
8887
double fnumberOfPostsmootherSteps = Af->mgData->numberOfPostsmootherSteps;

Diff for: testing/main.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ int main(int argc, char * argv[]) {
117117
Vector b, x, xexact;
118118
GenerateProblem(A, &b, &x, &xexact);
119119
SetupHalo(A);
120-
int numberOfMgLevels = 3; // Number of levels including first
120+
int numberOfMgLevels = 4; // Number of levels including first
121121
SparseMatrix * curLevelMatrix = &A;
122122
for (int level = 1; level< numberOfMgLevels; ++level) {
123123
GenerateCoarseProblem(*curLevelMatrix);

Diff for: tools/hpcg.dox

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ PROJECT_NAME = HPCG
3232
# This could be handy for archiving the generated documentation or
3333
# if some version control system is used.
3434

35-
PROJECT_NUMBER ="Version 1.1"
35+
PROJECT_NUMBER ="Version 2.0"
3636

3737
# Using the PROJECT_BRIEF tag one can provide an optional one line description
3838
# for a project that appears at the top of each page and should give viewer

Diff for: web/doc/HPCG-Logo.jpg

74.1 KB
Loading

Diff for: web/doc/HPCG-Logo.pptx

54 Bytes
Binary file not shown.

Diff for: web/doc/HPCG-Logo.tiff

5.48 KB
Binary file not shown.

0 commit comments

Comments
 (0)