Skip to content

Commit a4ffc8b

Browse files
authored
23075: Sets default value of use_sdm to True from None (#377)
1 parent 3b90523 commit a4ffc8b

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

howso/client/base.py

+4-6
Original file line numberDiff line numberDiff line change
@@ -4039,7 +4039,7 @@ def analyze(
40394039
targeted_model: t.Optional[TargetedModel] = None,
40404040
use_case_weights: t.Optional[bool] = None,
40414041
use_deviations: t.Optional[bool] = None,
4042-
use_sdm: t.Optional[bool] = None,
4042+
use_sdm: t.Optional[bool] = True,
40434043
weight_feature: t.Optional[str] = None,
40444044
**kwargs
40454045
):
@@ -4102,14 +4102,13 @@ def analyze(
41024102
will be used if the Trainee has them.
41034103
use_deviations : bool, optional
41044104
When True, uses deviations for LK metric in queries.
4105-
use_sdm : bool, default None,
4105+
use_sdm : bool, default True,
41064106
When True, Howso Engine will compute and use a sparse deviation
41074107
matrix (SDM) for each nominal feature in all similarity queries.
41084108
Enabling SDM will typically incur a small to moderate penalty on
41094109
speed when using nominal features in inference in exchange for
41104110
yielding higher quality inference. The magnitude of the changes are
41114111
dependent on relationships among the data and the task at hand.
4112-
Howso Engine will default to True, if left unset.
41134112
weight_feature : str, optional
41144113
Name of feature whose values to use as case weights.
41154114
When left unspecified uses the internally managed case weight.
@@ -4245,7 +4244,7 @@ def set_auto_analyze_params(
42454244
targeted_model: t.Optional[TargetedModel] = None,
42464245
use_deviations: t.Optional[bool] = None,
42474246
use_case_weights: t.Optional[bool] = None,
4248-
use_sdm: t.Optional[bool] = None,
4247+
use_sdm: t.Optional[bool] = True,
42494248
weight_feature: t.Optional[str] = None,
42504249
**kwargs
42514250
):
@@ -4318,14 +4317,13 @@ def set_auto_analyze_params(
43184317
If set to True, will scale influence weights by each case's
43194318
`weight_feature` weight. If unspecified, case weights
43204319
will be used if the Trainee has them.
4321-
use_sdm : bool, default None,
4320+
use_sdm : bool, default True,
43224321
When True, Howso Engine will compute and use a sparse deviation
43234322
matrix (SDM) for each nominal feature in all similarity queries.
43244323
Enabling SDM will typically incur a small to moderate penalty on
43254324
speed when using nominal features in inference in exchange for
43264325
yielding higher quality inference. The magnitude of the changes are
43274326
dependent on relationships among the data and the task at hand.
4328-
Howso Engine will default to True, if left unset.
43294327
weight_feature : str
43304328
Name of feature whose values to use as case weights.
43314329
When left unspecified uses the internally managed case weight.

howso/engine/trainee.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -1050,14 +1050,13 @@ def analyze(
10501050
be used if the Trainee has them.
10511051
use_deviations : bool, default False
10521052
When True, uses deviations for LK metric in queries.
1053-
use_sdm : bool, default None,
1053+
use_sdm : bool, default True,
10541054
When True, Howso Engine will compute and use a sparse deviation
10551055
matrix (SDM) for each nominal feature in all similarity queries.
10561056
Enabling SDM will typically incur a small to moderate penalty on
10571057
speed when using nominal features in inference in exchange for
10581058
yielding higher quality inference. The magnitude of the changes are
10591059
dependent on relationships among the data and the task at hand.
1060-
Howso Engine will default to True, if left unset.
10611060
weight_feature : str, optional
10621061
Name of feature whose values to use as case weights.
10631062
When left unspecified uses the internally managed case weight.

0 commit comments

Comments
 (0)