From 4c5962e6add32f3b51f935af096f590032957731 Mon Sep 17 00:00:00 2001
From: Taylor Smock <tsmock@meta.com>
Date: Tue, 28 Nov 2023 06:15:25 -0700
Subject: [PATCH] Update sidebar test for Rapid changes

Signed-off-by: Taylor Smock <tsmock@meta.com>
---
 frontend/src/components/rapidEditor.js        |  2 +-
 .../tests/actionSidebars.test.js              | 43 +++++++++++--------
 2 files changed, 26 insertions(+), 19 deletions(-)

diff --git a/frontend/src/components/rapidEditor.js b/frontend/src/components/rapidEditor.js
index 1db87a4f1a..05fbc219f9 100644
--- a/frontend/src/components/rapidEditor.js
+++ b/frontend/src/components/rapidEditor.js
@@ -288,7 +288,7 @@ RapidEditor.propTypes = {
   gpxUrl: PropTypes.string.isRequired,
   powerUser: PropTypes.bool.isRequired,
   showSidebar: PropTypes.bool.isRequired,
-}
+};
 
 export { RapidEditor, generateStartingHash, equalsUrlParameters, updateUrl };
 export default RapidEditor;
diff --git a/frontend/src/components/taskSelection/tests/actionSidebars.test.js b/frontend/src/components/taskSelection/tests/actionSidebars.test.js
index 413881ec70..bfd2770f9b 100644
--- a/frontend/src/components/taskSelection/tests/actionSidebars.test.js
+++ b/frontend/src/components/taskSelection/tests/actionSidebars.test.js
@@ -19,12 +19,16 @@ import {
 import { setupFaultyHandlers } from '../../../network/tests/server';
 import messages from '../messages';
 import { store } from '../../../store';
+import { TaskMapAction } from '../action';
+import { getProjectSummary } from '../../../network/tests/mockData/projects';
+import tasksGeojson from '../../../utils/tests/snippets/tasksGeometry';
+import { userMultipleLockedTasksDetails } from '../../../network/tests/mockData/userStats';
 
 jest.mock('react-hot-toast', () => ({
   error: jest.fn(),
 }));
 
-describe('Appeareance of unsaved map changes to be dealt with while mapping', () => {
+describe('Appearance of unsaved map changes to be dealt with while mapping', () => {
   test('when splitting a task', async () => {
     const { user } = renderWithRouter(
       <QueryClientProviders>
@@ -183,7 +187,7 @@ describe('Miscellaneous modals and prompts', () => {
   });
 });
 
-describe('Appeareance of unsaved map changes to be dealt with while validating', () => {
+describe('Appearance of unsaved map changes to be dealt with while validating', () => {
   test('when stopping validation session', async () => {
     const { user } = renderWithRouter(
       <QueryClientProviders>
@@ -340,31 +344,34 @@ describe('Toggling display of the sidebar', () => {
   });
 
   it('should call the sidebar toggle function for RAPID editor', async () => {
-    const restartMock = jest.fn();
+    // Testing the resize call cannot be done currently, due to the following reasons:
+    // 1. Jest cannot mock/spy on the function call
+    // 2. The test environment doesn't have width/height information
+    // 3. The resize call in Rapid cannot be mocked since it is difficult to (a) get the context and (b) mock the call prior to full initialization.
+    // const resizeMock = jest.fn();
+    // expect(resizeMock).toHaveBeenCalledTimes(1); // This should be at the end of the test
     const user = userEvent.setup();
-    const context = {
-      ui: jest.fn().mockReturnValue({
-        restart: restartMock,
-      }),
-    };
-    act(() => {
-      store.dispatch({ type: 'SET_RAPIDEDITOR', context: context });
-    });
-    const setShowSidebarMock = jest.fn();
-    render(
+    const { getByRole, queryByRole } = renderWithRouter(
       <QueryClientProviders>
         <ReduxIntlProviders>
-          <SidebarToggle setShowSidebar={setShowSidebarMock} activeEditor="RAPID" />
+          <TaskMapAction
+            project={getProjectSummary(123)}
+            projectIsReady
+            tasks={tasksGeojson}
+            activeTasks={userMultipleLockedTasksDetails.tasks}
+            action="MAPPING"
+            editor="RAPID"
+          />
         </ReduxIntlProviders>
       </QueryClientProviders>,
     );
     await user.click(
-      screen.getByRole('button', {
-        name: /hide sidebar/i,
+      getByRole('button', {
+        name: 'Hide sidebar',
       }),
     );
-    expect(setShowSidebarMock).toHaveBeenCalledTimes(1);
-    expect(restartMock).toHaveBeenCalledTimes(1);
+    expect(getByRole('generic', { name: 'Show sidebar' })).toBeVisible();
+    expect(queryByRole('button', { name: 'Hide sidebar' })).toBeNull();
   });
 });