Skip to content

Commit 70ffd01

Browse files
committed
Iteration
1 parent d33208f commit 70ffd01

File tree

6 files changed

+459
-527
lines changed

6 files changed

+459
-527
lines changed

.circleci/config.yml

+1
Original file line numberDiff line numberDiff line change
@@ -59,5 +59,6 @@ workflows:
5959
branches:
6060
only:
6161
- publishing-automation
62+
- master
6263
jobs:
6364
- publish_if_needed

.npmrc

-1
Original file line numberDiff line numberDiff line change
@@ -1 +0,0 @@
1-
//registry.npmjs.org/:_authToken=${NPM_TOKEN}

.vscode/extensions.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"recommendations": ["orta.vscode-jest", "editorconfig.editorconfig", "orta.vscode-jest"]
2+
"recommendations": ["orta.vscode-jest", "editorconfig.editorconfig"]
33
}

auto-publish/index.js

+9-4
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const {
1515
const answer = await doesReactDOMOrHotLoaderHasNewerVersionThanUs(
1616
"latest",
1717
"latest",
18-
"test-org-bnaya-2",
18+
"hot-loader",
1919
"_rc"
2020
);
2121

@@ -32,10 +32,12 @@ const {
3232
path.resolve(__dirname, "staging-area"),
3333
answer.reactDOMVersion,
3434
answer.reactHotLoaderVersion,
35-
"test-org-bnaya-2"
35+
"hot-loader"
3636
);
3737

38-
console.info("don't really publish yet", { patchedPackageDir });
38+
console.info("The patched code is ready, we don't really auto publish yet", { patchedPackageDir });
39+
console.warn("Gonna fail the builds until you publish the new version");
40+
process.exit(1);
3941

4042
// const publishStdOut = await execFile(
4143
// "yarn",
@@ -56,4 +58,7 @@ const {
5658
} else {
5759
console.info("Nothing to publish");
5860
}
59-
})();
61+
})().catch((e) => {
62+
console.error(e);
63+
process.exit(1);
64+
})

package.json

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
22
"private": true,
3-
"name": "@hot-loader/react-dom",
3+
"name": "@hot-loader/react-dom-publishing-infra",
44
"version": "0.0.0",
5-
"description": "The Hot version of React-DOM",
5+
"description": "Patching & publishing react-dom for hot loader support infra",
66
"main": "index.js",
77
"scripts": {
88
"clean": "rm -Rf target",
@@ -29,20 +29,20 @@
2929
"homepage": "https://github.com/hot-loader/react-dom#readme",
3030
"devDependencies": {
3131
"@types/fs-extra": "^8.0.0",
32-
"@types/jest": "^24.0.15",
32+
"@types/jest": "^24.0.18",
3333
"@types/node": "^10",
34-
"@types/semver": "^6.0.1",
35-
"jest": "^24.8.0",
34+
"@types/semver": "^6.0.2",
35+
"jest": "^24.9.0",
3636
"npm-run-all": "^4.1.5",
3737
"prettier": "^1.18.2",
38-
"typescript": "^3.5.2",
38+
"typescript": "^3.6.3",
3939
"yarn-deduplicate": "^1.1.1"
4040
},
4141
"dependencies": {
4242
"fs-extra": "^8.1.0",
4343
"loose-envify": "^1.1.0",
4444
"object-assign": "^4.1.1",
4545
"prop-types": "^15.6.2",
46-
"semver": "^6.2.0"
46+
"semver": "^6.3.0"
4747
}
4848
}

0 commit comments

Comments
 (0)