New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate deductions started coming again , same as #541 #580

Open

unreal0901 opened this issue Mar 11, 2025 · 1 comment

Contributor

unreal0901 commented Mar 11, 2025 •

edited by huly-for-github bot

Loading

Duplicated deductions are coming when generating payslip.
After this commit it started happening again: 0cad9a5

This issue was resolved by me in previous PR #542 , but it started happening again.
Can you check it please.

Steps to reproduce:

create a deduction
choose specific employees and also make sure to add more the 2 specific employees
Now we will have deductions duplicated for each payslip.
I have fixed it in my local, its happening because of include_all coming in database as True by default and also union is not working correctly.

Python version: 3.11.9
OS: amazon linux and window OS

The text was updated successfully, but these errors were encountered:

Owner

horilla-opensource commented Mar 11, 2025

Hi @unreal0901 ,

Thanks for catching this! It looks like the issue reappeared due to a merge conflict where the previous fix from PR #542 was lost

We updated the source code with your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment