Dev Container Support #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I just saw this PR. Thanks for doing this!! |
|
Can you update the README with some basic instructions on how to get it running after cloning the repo? Also I think we need to add emulinker/bin/ to the .gitignore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial development container support within VS Code. This uses a gradle docker image as its base and builds the kotlin language server to improve Kotlin support within VS Code, in addition to getting debugging support working.
The language server seems to be in a bit of development limbo right now (see their GitHub for more info), but it works well enough and it's the only option available. This still not as integrated as IntelliJ IDEA, but it's not trying to be. This should provide a more lightweight option for others to contribute code with.
Included extensions:
Let me know if you want to tweak the dev container at all, as I made some assumptions on the environment. The Docker and EditorConfig extensions aren't strictly necessary, but I felt they were probably useful enough to include.