Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map callback data to UUIDs stored in the database instead of plain responses #18

Open
CrsiX opened this issue Jan 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@CrsiX
Copy link
Member

CrsiX commented Jan 21, 2023

This would prevent two types of attacks against the bot and its users, replay attacks and user forgery.

How to do it: Instead of assigning callback data in the current form (with all relevant data contained) to the keyboard callback buttons, there should only be a random UUID. The bot then receives a callback, replaces the UUID with the data from the database and forwards it. It also needs to instantly drop the UUID and the data from the database, because otherwise replay attacks would be possible. Then, those two attacks would be mitigated.

@CrsiX CrsiX added the enhancement New feature or request label Jan 21, 2023
@CrsiX
Copy link
Member Author

CrsiX commented Jan 21, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant