Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit has changed from hooks.yaml -> .pre-commit-hooks.yaml #16

Closed
asottile opened this issue Jan 25, 2017 · 7 comments
Closed

pre-commit has changed from hooks.yaml -> .pre-commit-hooks.yaml #16

asottile opened this issue Jan 25, 2017 · 7 comments

Comments

@asottile
Copy link

Hello pre-commit hook implementer!

In version 0.12.0 pre-commit has changed the default location for the file formerly known as hooks.yaml to make it more convincing for others to add more hooks.

As such, a migration has to (unfortunately) occur.

For maximum compatibility it is suggested to cp hooks.yaml .pre-commit-hooks.yaml (at least for the migration period). A copy is suggested over a symlink unless you do not care for windows compatibility (and I wouldn't blame you!).

Once the migration period is over (or you no longer care to support old versions of pre-commit), the hooks.yaml file is no longer necessary and may be deleted.

See pre-commit/pre-commit#470 for more details

Thanks again for contributing to the pre-commit ecosystem, we couldn't do it without you :)
Anthony

@asottile
Copy link
Author

asottile commented Aug 1, 2017

This repository has been temporarily removed from pre-commit.com as the latest version of pre-commit (0.16.0) has removed support for legacy hooks.yaml. Without providing .pre-commit-hooks.yaml, users will be unable to use this hook repository with pre-commit>=0.16.0.

@FatherShawn
Copy link

FatherShawn commented Aug 2, 2017

We use these plugins at our company all day long, so I've forked the repo to digitalpulp/pre-commit-php. I'll pull @djun-kim #21 into that repo and push it up in a moment.

@asottile
Copy link
Author

asottile commented Aug 2, 2017

@FatherShawn sweet, I'll add that repo for the time being as this one seems to be no longer maintained

@FatherShawn
Copy link

@asottile Thanks! We are super grateful to Yelp for pre-commit and to Hootsuite for contributing th e PHP hooks. And we are happy to take them over since this issue has been open for so long.

@asottile
Copy link
Author

asottile commented Aug 2, 2017

See pre-commit/pre-commit.com#123

@asottile
Copy link
Author

asottile commented Aug 2, 2017

👍 there's probably one or more of these PRs you'll want to incorporate as well: https://github.com/hootsuite/pre-commit-php/pulls

@asottile
Copy link
Author

closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants