Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMX property values that can contain '=' characters break parsing #17

Open
johlandabee opened this issue Jun 18, 2020 · 0 comments · May be fixed by #18
Open

VMX property values that can contain '=' characters break parsing #17

johlandabee opened this issue Jun 18, 2020 · 0 comments · May be fixed by #18

Comments

@johlandabee
Copy link

VMX property values that can contain '=' characters break parsing due to how loadVMXMap() is implemented:

govmx/decode.go

Lines 54 to 57 in 983fd93

parts := strings.Split(line, "=")
if len(parts) != 2 {
errors = appendErrors(errors, fmt.Errorf("Invalid line: %s ", line))
}

This came up while trying to create machines with https://github.com/hooklift/terraform-provider-vix using this https://app.vagrantup.com/generic/boxes/ubuntu1804/versions/3.0.10/providers/vmware_desktop.box Vagrant box.

The box has a guestos.detailed.data property defined with the value bitness='64' distroName='Ubuntu' distroVersion='18.04' familyName='Linux' kernelVersion='4.15.0-76-generic' prettyName='Ubuntu 18.04.4 LTS'

I'll submit a pull request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix parsing for property values containing '=' johlandabee/govmx
1 participant
@johlandabee