-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for external templates #62
Comments
Found this issue which is similar to this one - honojs/starter#14, we can do something similar here. |
Hi @MathurAditya724 ! I've also thought it would be good if Currently, we use Or, in the future, we can't say it's 100% No that Anyway, this should be considered. Plus, regarding |
I propose using To implement this, we can use regex to determine the appropriate git provider for the templates. I need to investigate whether Please let me know if you have any further concerns or suggestions. Otherwise, I will start working on the PR so we can evaluate this approach more thoroughly. |
Cool! Shall we start to work on replacing cc: @goisaki @ryuapp If you have any opinions on these issues, please share them. @MathurAditya724 can create a PR, and you can review it. |
Created the first PR for removing |
It's hard to support completely external community templates. The reason is security and reliability issues. Therefore, I think that unless |
I will start working on the new PR for adding |
Still, we have to consider if it should have I agree @ryuapp 's opinion:
|
For security, I agree with @ryuapp. Adding a warning banner when accessing 3rd party repositories is a good approach because hosting all the templates in a single repository can be challenging to maintain and scale. This is how I have planned to resolve this issue, I have divided this issue into 3 parts (3 PRs) -
|
Can we add support for
--template
or something through which we can use external templates?This is how the usage will be
pnpm create hono@latest --template=repo_addr
. I understand that we can usedegit
but it's mainly useful because of the hooks.If you want I can create the PR for this
The text was updated successfully, but these errors were encountered: